WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125713
LLInt should not conditionally branch to to labels outside of its function
https://bugs.webkit.org/show_bug.cgi?id=125713
Summary
LLInt should not conditionally branch to to labels outside of its function
Mark Hahnenberg
Reported
2013-12-13 15:01:40 PST
Right now we generate the following: bne _llint_throw_from_slow_path_trampoline which clang/llvm do not like. The fix is to use an unconditional jmp to the label combined with a conditional branch around the jmp.
Attachments
Patch
(2.02 KB, patch)
2013-12-13 15:04 PST
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2013-12-13 15:01:51 PST
<
rdar://problem/15660682
>
Mark Hahnenberg
Comment 2
2013-12-13 15:04:47 PST
Created
attachment 219203
[details]
Patch
Geoffrey Garen
Comment 3
2013-12-13 15:19:52 PST
Comment on
attachment 219203
[details]
Patch r=me
WebKit Commit Bot
Comment 4
2013-12-13 15:54:30 PST
Comment on
attachment 219203
[details]
Patch Clearing flags on attachment: 219203 Committed
r160571
: <
http://trac.webkit.org/changeset/160571
>
WebKit Commit Bot
Comment 5
2013-12-13 15:54:32 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug