Bug 125713 - LLInt should not conditionally branch to to labels outside of its function
Summary: LLInt should not conditionally branch to to labels outside of its function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-13 15:01 PST by Mark Hahnenberg
Modified: 2013-12-13 15:54 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2013-12-13 15:04 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-12-13 15:01:40 PST 
Right now we generate the following:

bne _llint_throw_from_slow_path_trampoline

which clang/llvm do not like. 

The fix is to use an unconditional jmp to the label combined with a conditional branch around the jmp.
Comment 1 Mark Hahnenberg 2013-12-13 15:01:51 PST 
<rdar://problem/15660682>
Comment 2 Mark Hahnenberg 2013-12-13 15:04:47 PST 
Created attachment 219203 [details]
Patch
Comment 3 Geoffrey Garen 2013-12-13 15:19:52 PST 
Comment on attachment 219203 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2013-12-13 15:54:30 PST 
Comment on attachment 219203 [details]
Patch

Clearing flags on attachment: 219203

Committed r160571: <http://trac.webkit.org/changeset/160571>
Comment 5 WebKit Commit Bot 2013-12-13 15:54:32 PST 
All reviewed patches have been landed.  Closing bug.