Bug 125708 - Web Inspector: support negative numbers in secondsToString and bytesToString
Summary: Web Inspector: support negative numbers in secondsToString and bytesToString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-12-13 13:18 PST by Timothy Hatcher
Modified: 2014-01-10 15:50 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.01 KB, patch)
2013-12-13 13:21 PST, Timothy Hatcher
joepeck: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (3.32 KB, patch)
2014-01-10 15:16 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-12-13 13:18:50 PST
Right now all negative numbers go though the smallest unit path.
Comment 1 Timothy Hatcher 2013-12-13 13:21:50 PST
Created attachment 219190 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-13 13:30:50 PST
Comment on attachment 219190 [details]
Patch

Rejecting attachment 219190 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 219190, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ffs from patch file(s).
patching file Source/WebInspectorUI/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebInspectorUI/UserInterface/Utilities.js
Hunk #1 succeeded at 775 (offset -124 lines).
Hunk #2 FAILED at 808.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Utilities.js.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/48648226
Comment 3 Timothy Hatcher 2014-01-10 15:16:46 PST
Created attachment 220895 [details]
Patch for landing
Comment 4 Radar WebKit Bug Importer 2014-01-10 15:18:18 PST
<rdar://problem/15796622>
Comment 5 WebKit Commit Bot 2014-01-10 15:50:08 PST
Comment on attachment 220895 [details]
Patch for landing

Clearing flags on attachment: 220895

Committed r161689: <http://trac.webkit.org/changeset/161689>
Comment 6 WebKit Commit Bot 2014-01-10 15:50:10 PST
All reviewed patches have been landed.  Closing bug.