Bug 125707 – Web Inspector: Move Inspector and Debugger protocol domains into JavaScriptCore

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Move a few other domains into JavaScriptCore that we will eventually need in JavaScriptCore.

In doing this, there was a dependency in the Debugger protocol on Page.SearchMatch type. So to fix this, I create a new domain "GenericTypes" that only contains types that can be shared by everyone. I put this domain in JavaScriptCore and avoid generating frontend/backend/backendcommands for this class, only typebuilders.

[Joseph Pecoraro]

Created attachment 219191 [details]
[PATCH] Proposed Fix

[Build Bot]

Comment on attachment 219191 [details]
[PATCH] Proposed Fix

Attachment 219191 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/48638260

New failing tests:
inspector-protocol/debugger/setBreakpoint-options-exception.html
inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html
inspector-protocol/debugger/breakpoint-action-detach.html
inspector-protocol/debugger/breakpoint-action-with-exception.html
inspector-protocol/debugger/setBreakpoint-actions.html

[Build Bot]

Created attachment 219205 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Joseph Pecoraro]

That sounds like a red flag! I'll investigate.

[Build Bot]

Comment on attachment 219191 [details]
[PATCH] Proposed Fix

Attachment 219191 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/48628268

New failing tests:
inspector-protocol/debugger/setBreakpoint-options-exception.html
inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html
inspector-protocol/debugger/breakpoint-action-detach.html
inspector-protocol/debugger/breakpoint-action-with-exception.html
inspector-protocol/debugger/setBreakpoint-actions.html

[Build Bot]

Created attachment 219206 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Joseph Pecoraro]

Created attachment 219208 [details]
[DIFF] Extra Changes

These are the changes I have to make to fix the issue seen in inspector-protocol/debugger tests.

I have no idea how the compiler was compiling this without warnings. This had crossed my mind before, and these test failures just made it very obvious.

There were two Inspector::TypeBuilder::getEnumConstantValue functions, now there will be one for each TypeBuilder output file. So:

    Inspector::TypeBuilder::getJSEnumConstantValue(...)
    Inspector::TypeBuilder::getWebEnumConstantValue(...)

[Joseph Pecoraro]

Created attachment 219211 [details]
[PATCH] Improved Fix

[Joseph Pecoraro]

Landed r160588: <http://trac.webkit.org/changeset/160588>