Bug 125703 - [MSE] Update duration after appending samples, per spec.
Summary: [MSE] Update duration after appending samples, per spec.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-13 12:54 PST by Jer Noble
Modified: 2013-12-17 16:54 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.06 KB, patch)
2013-12-13 13:04 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-12-13 12:54:33 PST 
[MSE] Update duration after appending samples, per spec.
Comment 1 Jer Noble 2013-12-13 13:04:46 PST 
Created attachment 219187 [details]
Patch
Comment 2 Eric Carlson 2013-12-13 14:53:40 PST 
Comment on attachment 219187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219187&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1010
> +    if (highestPresentationEndTimestamp().toDouble() > m_source->duration())
> +        m_source->setDuration(highestPresentationEndTimestamp().toDouble(), IgnorableExceptionCode());

Nit: it will be more efficient to put the timestamp in a variable instead of calculating it twice.

> LayoutTests/media/media-source/media-source-duration-after-append.html:16
> +    function runTest() {

Nit: wrong place for the opening brace.
Comment 3 WebKit Commit Bot 2013-12-17 16:54:29 PST 
Comment on attachment 219187 [details]
Patch

Clearing flags on attachment: 219187

Committed r160739: <http://trac.webkit.org/changeset/160739>
Comment 4 WebKit Commit Bot 2013-12-17 16:54:31 PST 
All reviewed patches have been landed.  Closing bug.