[WK2] Start removing calls to String::characters()
Created attachment 219182 [details] Patch
Comment on attachment 219182 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219182&action=review > Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:55 > + RetainPtr<CFStringRef> directoryCFString = directory.createCFString(); auto. > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:912 > + loadDataImpl(sharedBuffer, MIMEType, ASCIILiteral("utf-8"), baseURL, unreachableURL, decoder); This has to be latin-1.
Committed r160572: <http://trac.webkit.org/changeset/160572>
This broke some unit tests: Tests that failed: WebKit2WillLoadTest.WKPageLoadAlternateHTMLString WebKit2WillLoadTest.WKPageLoadAlternateHTMLStringWithUserData WebKit2WillLoadTest.WKPageLoadHTMLString WebKit2WillLoadTest.WKPageLoadHTMLStringWithUserData WebKit2WillLoadTest.WKPageLoadPlainTextString WebKit2WillLoadTest.WKPageLoadPlainTextStringWithUserData Tests that timed out: WKBrowsingContextLoadDelegateTest.SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL The last one is still timing out on ToT: WKBrowsingContextLoadDelegateTest.SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/11839
> The last one is still timing out on ToT: > WKBrowsingContextLoadDelegateTest.SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL And still. Filed bug 125810 about that.