Bug 125697 - Add page load delegate for WebProcessPlugInBrowsingContextController.
Summary: Add page load delegate for WebProcessPlugInBrowsingContextController.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-13 12:28 PST by Yongjun Zhang
Modified: 2016-11-09 09:26 PST (History)
6 users (show)

See Also:

Attachments
Add page load delegate to WKWebProcessPlugInBrowsingContextController. (12.26 KB, patch)
2013-12-13 13:07 PST, Yongjun Zhang 		sam: review+
Details | Formatted Diff | Diff
address review comments before landing. (12.31 KB, patch)
2013-12-14 21:54 PST, Yongjun Zhang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2013-12-13 12:28:34 PST 
We should add page load delegate for WebProcessPlugInBrowsingContextController so that a WebProcess InjectedBundle can listen to page load events.
Comment 1 Yongjun Zhang 2013-12-13 13:07:34 PST 
Created attachment 219188 [details]
Add page load delegate to WKWebProcessPlugInBrowsingContextController.
Comment 2 Sam Weinig 2013-12-14 18:02:12 PST 
Comment on attachment 219188 [details]
Add page load delegate to WKWebProcessPlugInBrowsingContextController.

View in context: https://bugs.webkit.org/attachment.cgi?id=219188&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:82
> +static void setUpPageLoaderClient(WKWebProcessPlugInBrowserContextController *contextController, WebPage &page)

& on the wrong side.
Comment 3 Yongjun Zhang 2013-12-14 21:54:42 PST 
Created attachment 219270 [details]
address review comments before landing.
Comment 4 WebKit Commit Bot 2013-12-14 22:29:17 PST 
Comment on attachment 219270 [details]
address review comments before landing.

Clearing flags on attachment: 219270

Committed r160616: <http://trac.webkit.org/changeset/160616>
Comment 5 WebKit Commit Bot 2013-12-14 22:29:19 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogonác 2016-11-09 09:26:09 PST 
Comment on attachment 219270 [details]
address review comments before landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=219270&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:37
> +#import "WKWebProcessPluginFrameInternal.h"

It's not WKWebProcessPlug_i_nFrameInternal.h, but WKWebProcessPlug_I_nFrameInternal.h

Fixed in https://trac.webkit.org/changeset/208431