Bug 125691 - [GTK] Expose also webkit_dom_document_get_url
Summary: [GTK] Expose also webkit_dom_document_get_url
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2013-12-13 04:19 PST by Carlos Garcia Campos
Modified: 2013-12-13 04:37 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.41 KB, patch)
2013-12-13 04:21 PST, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-12-13 04:19:17 PST 
For some reason we expose the URL property, so it can be accessed with g_object_get(), but we have a special case to not provide a public getter.
Comment 1 Carlos Garcia Campos 2013-12-13 04:21:03 PST 
Created attachment 219166 [details]
Patch
Comment 2 Martin Robinson 2013-12-13 04:24:41 PST 
Comment on attachment 219166 [details]
Patch

Were you able to figure out why the getter wasn't exposed?
Comment 3 Carlos Garcia Campos 2013-12-13 04:31:08 PST 
(In reply to comment #2)
> (From update of attachment 219166 [details])
> Were you able to figure out why the getter wasn't exposed?

Nope, looked at git blame and that exception is there since the very beginning. My guess is that the property was added and the check for the public method was forgotten.
Comment 4 Carlos Garcia Campos 2013-12-13 04:37:09 PST 
Committed r160543: <http://trac.webkit.org/changeset/160543>