Bug 125683 - [GTK] [CMake] Build the WebKit2 GObject API tests
Summary: [GTK] [CMake] Build the WebKit2 GObject API tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 115966
  Show dependency tree / graph
 
Reported: 2013-12-13 00:50 PST by Martin Robinson
Modified: 2013-12-23 13:46 PST (History)
3 users (show)

See Also:

Attachments
Patch (9.07 KB, patch)
2013-12-22 11:39 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (18.03 KB, patch)
2013-12-22 11:40 PST, Martin Robinson 		gustavo: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-12-13 00:50:17 PST 
We need CMake to build the WebKit2 GObject API tests.
Comment 1 Martin Robinson 2013-12-22 11:39:55 PST 
Created attachment 219878 [details]
Patch
Comment 2 Martin Robinson 2013-12-22 11:40:38 PST 
Created attachment 219879 [details]
Patch
Comment 3 Gustavo Noronha (kov) 2013-12-22 12:50:09 PST 
Comment on attachment 219879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219879&action=review

hmm I'm confuse. This seems to also add the wk1 version of the GObject API tests!

> Source/PlatformGTK.cmake:3
> +if (ENABLE_WEBKIT)
> +    add_subdirectory(${WEBKIT_DIR}/gtk/tests)
> +endif ()

This actually makes more sense than the patch I r+ed in the other bug heh.
Comment 4 Martin Robinson 2013-12-22 13:11:33 PST 
Comment on attachment 219878 [details]
Patch

Looks like I tried to get a bit too fancy with webkit-patch. I managed to upload the wrong patch to this bug and obsolete the real patch.
Comment 5 Martin Robinson 2013-12-22 13:11:55 PST 
Comment on attachment 219878 [details]
Patch

The patch marked for review should be the real one now.
Comment 6 Daniel Bates 2013-12-23 13:10:04 PST 
Comment on attachment 219879 [details]
Patch

Obsoleting patch per comment 5.
Comment 7 Daniel Bates 2013-12-23 13:30:28 PST 
Comment on attachment 219878 [details]
Patch

This looks sane to me.
Comment 8 Martin Robinson 2013-12-23 13:46:17 PST 
Comment on attachment 219878 [details]
Patch

Clearing flags on attachment: 219878

Committed r161016: <http://trac.webkit.org/changeset/161016>
Comment 9 Martin Robinson 2013-12-23 13:46:20 PST 
All reviewed patches have been landed.  Closing bug.