WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125677
CStack Branch: Use proper values for stack checks
https://bugs.webkit.org/show_bug.cgi?id=125677
Summary
CStack Branch: Use proper values for stack checks
Michael Saboff
Reported
2013-12-12 21:22:12 PST
Each of the JavaScript engines needs to check for available stack on entry to a function. This is done by subtracting a value from the callFrameRegister and then making sure it is greater than VM::m_jsStackLimit. Each engine gets the value a slightly different way. The LLInt should use CodeBlock::m_numCalleeRegisters * register size + maxFrameExtentForSlowPathCall The baseline JIT should use frameRegisterCountFor() The DFG should use Graph::requiredRegisterCountForExecutionAndExit()
Attachments
Patch
(3.81 KB, patch)
2013-12-12 21:32 PST
,
Michael Saboff
fpizlo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2013-12-12 21:32:10 PST
Created
attachment 219152
[details]
Patch
Michael Saboff
Comment 2
2013-12-12 21:48:34 PST
Committed
r160527
: <
http://trac.webkit.org/changeset/160527
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug