Bug 125669 – CStack Branch: Add equivalent values from MaxFrameExtentForSlowPathCall.h to lint files

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

The port specific values of maxFrameExtentForSlowPathCall in assembler/MaxFrameExtentForSlowPathCall.h also need to be added to LowLevelInterpreter.asm.

[Michael Saboff]

Created attachment 219137 [details]
Patch

[WebKit Commit Bot]

Attachment 219137 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/llint/LLIntData.cpp', u'Source/JavaScriptCore/llint/LowLevelInterpreter.asm', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:128:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Lam]

Comment on attachment 219137 [details]
Patch

r=me

[EFL EWS Bot]

Comment on attachment 219137 [details]
Patch

Attachment 219137 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/48648018

[EFL EWS Bot]

Comment on attachment 219137 [details]
Patch

Attachment 219137 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/48658025

[kov's GTK+ EWS bot]

Comment on attachment 219137 [details]
Patch

Attachment 219137 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/48618026

[Mark Lam]

Comment on attachment 219137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219137&action=review

> Source/JavaScriptCore/llint/LLIntData.cpp:131
> +#elif CPU(ARM) || CPU(SH4)
> +    ASSERT(maxFrameExtentForSlowPathCall == 16);

Since CPU(ARM) covers both the CPU(ARM_TRADITIONAL) and CPU(ARM_THUMB2) cases, can you change the #if in MaxFrameExtentForSlowPathCall.h to reflect this (so that this list looks consistent with the one there)?

[Michael Saboff]

Committed r160522: <http://trac.webkit.org/changeset/160522>