Bug 125667 – WK2: Add support for inline candidates on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Enrica Casucci]

We need to support the equivalent of input methods on iOS using WebKit2

[Enrica Casucci]

Created attachment 219135 [details]
Patch

[Benjamin Poulain]

Comment on attachment 219135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219135&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:1124
> +    void revealSelection();

What about renaming this to notifyRevealedSelection, and renaming WebChromeClient::notifyRevealedSelectionByScrollingFrame to WebChromeClient::notifyRevealedSelection()?

> Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm:1413
> +    _markedText = (_page->editorState().hasComposition) ? _page->editorState().markedText : String();

String() -> nil?

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:634
> +            result.lastMarkedRect = compositionRects[compositionRects.size() - 1].rect();

I think you can just use compositionRects.last().rect() here.

[Enrica Casucci]

(In reply to comment #2)
Thanks for the review.
> (From update of attachment 219135 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219135&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.h:1124
> > +    void revealSelection();
> 
> What about renaming this to notifyRevealedSelection, and renaming WebChromeClient::notifyRevealedSelectionByScrollingFrame to WebChromeClient::notifyRevealedSelection()?
Yes, I'll do that.
> 
> > Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm:1413
> > +    _markedText = (_page->editorState().hasComposition) ? _page->editorState().markedText : String();
> 
> String() -> nil?
the compiler complains. Not sure I understand why....
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:634
> > +            result.lastMarkedRect = compositionRects[compositionRects.size() - 1].rect();
> 
> I think you can just use compositionRects.last().rect() here.
Done.

[Enrica Casucci]

Actually I will rename the WebChromeClient method in a later patch.
I also want to remove the WebFrame parameter that is unused in both WebKit2 and WebKit1 implementations.

[Enrica Casucci]

Committed revision 160566.