Bug 125664 – Web Inspector: Fix Type Dependency Issues

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

There are some type dependency issues where Domains in JavaScriptCore depended on types in WebCore.

We should come up with proper fixes for these issues, so that we can safely share the types between all places.

At the moment, my intended workaround has been to duplicate the type with different names in JSC and WebCore.

[Joseph Pecoraro]

• Runtime.RuntimeFrameId duplicates Network.FrameId
• Debugger.DebuggerSearchMatch duplicates Page.SearchMatch

One approach would be to just reverse the dependency, and define it in the lower domain. However I think this may need to addressed on a case by case basis:

    • FrameId doesn't belong in Runtime. Maybe a more generic type name should used.
    • SearchMatch doesn't need to be in a specific domain. Maybe we should have a place of shared types everywhere. E.g. a Type domain which has no commands, just very generic types.

[Radar WebKit Bug Importer]

<rdar://problem/18819515>

[Joseph Pecoraro]

Created attachment 240643 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

(In reply to comment #1)
> • Debugger.DebuggerSearchMatch duplicates Page.SearchMatch

This was worked around by GenericTypes.json. I'll keep that for now, I think its a worthwhile concept.

[Brian Burg]

Comment on attachment 240643 [details]
[PATCH] Proposed Fix

Thanks for the cleanup!

[WebKit Commit Bot]

Comment on attachment 240643 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 240643

Committed r175362: <http://trac.webkit.org/changeset/175362>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.