RESOLVED FIXED 125662
Add a few more ASCIILiterals 
https://bugs.webkit.org/show_bug.cgi?id=125662
Summary Add a few more ASCIILiterals
Joseph Pecoraro
Reported 2013-12-12 15:14:45 PST
Some string constants are turning into WTF::Strings, so they can use ASCIILiteral. They eventually get put into an InspectorObject.
Attachments
[PATCH] Proposed Fix (3.23 KB, patch)
2013-12-12 15:15 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2013-12-12 15:15:57 PST
Created attachment 219127 [details] [PATCH] Proposed Fix
Darin Adler
Comment 2 2013-12-12 17:49:00 PST
Comment on attachment 219127 [details] [PATCH] Proposed Fix OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size.
Joseph Pecoraro
Comment 3 2013-12-12 17:58:49 PST
(In reply to comment #2) > (From update of attachment 219127 [details]) > OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size. Note shown in the context of the patch, there is another case that returns a concatenation of strings, which would be harder to do if the arguments was a const char*.
Joseph Pecoraro
Comment 4 2013-12-12 18:05:40 PST
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 219127 [details] [details]) > > OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size. > > Note shown in the context of the patch, there is another case that returns a concatenation of strings, which would be harder to do if the arguments was a const char*. Wow, horrible English. Not* shown ... if the argument* was ...
WebKit Commit Bot
Comment 5 2013-12-12 18:16:22 PST
Comment on attachment 219127 [details] [PATCH] Proposed Fix Clearing flags on attachment: 219127 Committed r160523: <http://trac.webkit.org/changeset/160523>
WebKit Commit Bot
Comment 6 2013-12-12 18:16:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.