Bug 125657 - Fix a silly mistake of r160467
Summary: Fix a silly mistake of r160467
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-12 14:40 PST by Benjamin Poulain
Modified: 2013-12-12 19:50 PST (History)
1 user (show)

See Also:

Attachments
Patch (7.56 KB, patch)
2013-12-12 14:41 PST, Benjamin Poulain 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-12-12 14:40:01 PST 
Fix a silly mistake of r160467
Comment 1 Benjamin Poulain 2013-12-12 14:41:16 PST 
Created attachment 219121 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-12-12 15:04:26 PST 
Comment on attachment 219121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219121&action=review

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:136
> +        if (!!protector->hasHandle()) {

Can we just use "if (protector->hasHandle())"?

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:164
> -        if (!protector->hasHandle()) {
> +        if (!!protector->hasHandle()) {

Ditto

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:197
> +        if (!!protector->hasHandle()) {

Ditto.

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:272
> +        if (!!protector->hasHandle()) {

Ditto
Comment 3 Benjamin Poulain 2013-12-12 16:29:17 PST 
(In reply to comment #2)
> (From update of attachment 219121 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219121&action=review
> 
> > Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:136
> > +        if (!!protector->hasHandle()) {
> 
> Can we just use "if (protector->hasHandle())"?

Of course :)
Will fix.
Comment 4 Benjamin Poulain 2013-12-12 19:50:42 PST 
Committed r160525: <http://trac.webkit.org/changeset/160525>