RESOLVED FIXED Bug 125646
[iOS] Upstream WebCore/dom changes 
https://bugs.webkit.org/show_bug.cgi?id=125646
Summary [iOS] Upstream WebCore/dom changes
Daniel Bates
Reported 2013-12-12 11:26:32 PST
Upstream the iOS related changes to WebCore/dom.
Attachments
Patch (106.11 KB, patch)
2013-12-12 11:35 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (107.28 KB, patch)
2013-12-12 12:19 PST, Daniel Bates 		ddkilzer: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2013-12-12 11:35:12 PST
Created attachment 219102 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-12 11:36:57 PST
Attachment 219102 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/ActiveDOMObject.h', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/DeviceMotionClient.h', u'Source/WebCore/dom/DeviceMotionController.cpp', u'Source/WebCore/dom/DeviceMotionController.h', u'Source/WebCore/dom/DeviceOrientationClient.h', u'Source/WebCore/dom/DeviceOrientationController.cpp', u'Source/WebCore/dom/DeviceOrientationController.h', u'Source/WebCore/dom/DeviceOrientationData.cpp', u'Source/WebCore/dom/DeviceOrientationData.h', u'Source/WebCore/dom/DeviceOrientationEvent.idl', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/Document.idl', u'Source/WebCore/dom/DocumentMarker.h', u'Source/WebCore/dom/DocumentMarkerController.cpp', u'Source/WebCore/dom/DocumentMarkerController.h', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/EventContext.cpp', u'Source/WebCore/dom/EventContext.h', u'Source/WebCore/dom/EventDispatcher.cpp', u'Source/WebCore/dom/EventNames.h', u'Source/WebCore/dom/EventNames.in', u'Source/WebCore/dom/MouseRelatedEvent.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/Position.h', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/dom/Range.h', u'Source/WebCore/dom/ScriptExecutionContext.cpp', u'Source/WebCore/dom/TreeScope.cpp', u'Source/WebCore/dom/ViewportArguments.cpp', u'Source/WebCore/dom/ViewportArguments.h', u'Source/WebCore/dom/make_names.pl', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/Settings.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/dom/EventNames.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/EventNames.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/EventNames.h:273: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/EventNames.h:277: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 3 2013-12-12 12:01:40 PST
Comment on attachment 219102 [details] Patch Attachment 219102 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/45288088
EFL EWS Bot
Comment 4 2013-12-12 12:18:15 PST
Comment on attachment 219102 [details] Patch Attachment 219102 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/48438003
Build Bot
Comment 5 2013-12-12 12:18:31 PST
Comment on attachment 219102 [details] Patch Attachment 219102 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/48398001
Daniel Bates
Comment 6 2013-12-12 12:19:28 PST
Created attachment 219108 [details] Patch
WebKit Commit Bot
Comment 7 2013-12-12 12:21:55 PST
Attachment 219108 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/ActiveDOMObject.h', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/DeviceMotionClient.h', u'Source/WebCore/dom/DeviceMotionController.cpp', u'Source/WebCore/dom/DeviceMotionController.h', u'Source/WebCore/dom/DeviceOrientationClient.h', u'Source/WebCore/dom/DeviceOrientationController.cpp', u'Source/WebCore/dom/DeviceOrientationController.h', u'Source/WebCore/dom/DeviceOrientationData.cpp', u'Source/WebCore/dom/DeviceOrientationData.h', u'Source/WebCore/dom/DeviceOrientationEvent.idl', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/Document.idl', u'Source/WebCore/dom/DocumentMarker.h', u'Source/WebCore/dom/DocumentMarkerController.cpp', u'Source/WebCore/dom/DocumentMarkerController.h', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/EventContext.cpp', u'Source/WebCore/dom/EventContext.h', u'Source/WebCore/dom/EventDispatcher.cpp', u'Source/WebCore/dom/EventNames.h', u'Source/WebCore/dom/EventNames.in', u'Source/WebCore/dom/MouseRelatedEvent.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/Position.h', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/dom/Range.h', u'Source/WebCore/dom/ScriptExecutionContext.cpp', u'Source/WebCore/dom/TreeScope.cpp', u'Source/WebCore/dom/ViewportArguments.cpp', u'Source/WebCore/dom/ViewportArguments.h', u'Source/WebCore/dom/make_names.pl', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/Settings.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/dom/EventNames.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/EventNames.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/EventNames.h:273: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/EventNames.h:277: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Kilzer (:ddkilzer)
Comment 8 2013-12-16 16:43:39 PST
Comment on attachment 219108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219108&action=review r=me > Source/WebCore/dom/DOMImplementation.cpp:352 > -#if ENABLE(VIDEO) > +#if ENABLE(VIDEO) && !PLATFORM(IOS) Would this be written better as: #if ENABLE(VIDEO) && !ENABLE(PLUGIN_PROXY_FOR_VIDEO)
Daniel Bates
Comment 9 2013-12-16 17:29:04 PST
Committed r160679: <http://trac.webkit.org/changeset/160679>
Note You need to log in before you can comment on or make changes to this bug.