Bug 125646 - [iOS] Upstream WebCore/dom changes
Summary: [iOS] Upstream WebCore/dom changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks: 125765
  Show dependency treegraph
 
Reported: 2013-12-12 11:26 PST by Daniel Bates
Modified: 2013-12-16 17:29 PST (History)
14 users (show)

See Also:


Attachments
Patch (106.11 KB, patch)
2013-12-12 11:35 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (107.28 KB, patch)
2013-12-12 12:19 PST, Daniel Bates
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-12-12 11:26:32 PST
Upstream the iOS related changes to WebCore/dom.
Comment 1 Daniel Bates 2013-12-12 11:35:12 PST
Created attachment 219102 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-12 11:36:57 PST
Attachment 219102 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/ActiveDOMObject.h', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/DeviceMotionClient.h', u'Source/WebCore/dom/DeviceMotionController.cpp', u'Source/WebCore/dom/DeviceMotionController.h', u'Source/WebCore/dom/DeviceOrientationClient.h', u'Source/WebCore/dom/DeviceOrientationController.cpp', u'Source/WebCore/dom/DeviceOrientationController.h', u'Source/WebCore/dom/DeviceOrientationData.cpp', u'Source/WebCore/dom/DeviceOrientationData.h', u'Source/WebCore/dom/DeviceOrientationEvent.idl', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/Document.idl', u'Source/WebCore/dom/DocumentMarker.h', u'Source/WebCore/dom/DocumentMarkerController.cpp', u'Source/WebCore/dom/DocumentMarkerController.h', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/EventContext.cpp', u'Source/WebCore/dom/EventContext.h', u'Source/WebCore/dom/EventDispatcher.cpp', u'Source/WebCore/dom/EventNames.h', u'Source/WebCore/dom/EventNames.in', u'Source/WebCore/dom/MouseRelatedEvent.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/Position.h', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/dom/Range.h', u'Source/WebCore/dom/ScriptExecutionContext.cpp', u'Source/WebCore/dom/TreeScope.cpp', u'Source/WebCore/dom/ViewportArguments.cpp', u'Source/WebCore/dom/ViewportArguments.h', u'Source/WebCore/dom/make_names.pl', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/Settings.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/dom/EventNames.h:268:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/EventNames.h:271:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/EventNames.h:273:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/EventNames.h:277:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EFL EWS Bot 2013-12-12 12:01:40 PST
Comment on attachment 219102 [details]
Patch

Attachment 219102 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/45288088
Comment 4 EFL EWS Bot 2013-12-12 12:18:15 PST
Comment on attachment 219102 [details]
Patch

Attachment 219102 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/48438003
Comment 5 Build Bot 2013-12-12 12:18:31 PST
Comment on attachment 219102 [details]
Patch

Attachment 219102 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/48398001
Comment 6 Daniel Bates 2013-12-12 12:19:28 PST
Created attachment 219108 [details]
Patch
Comment 7 WebKit Commit Bot 2013-12-12 12:21:55 PST
Attachment 219108 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/ActiveDOMObject.h', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/DeviceMotionClient.h', u'Source/WebCore/dom/DeviceMotionController.cpp', u'Source/WebCore/dom/DeviceMotionController.h', u'Source/WebCore/dom/DeviceOrientationClient.h', u'Source/WebCore/dom/DeviceOrientationController.cpp', u'Source/WebCore/dom/DeviceOrientationController.h', u'Source/WebCore/dom/DeviceOrientationData.cpp', u'Source/WebCore/dom/DeviceOrientationData.h', u'Source/WebCore/dom/DeviceOrientationEvent.idl', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/Document.idl', u'Source/WebCore/dom/DocumentMarker.h', u'Source/WebCore/dom/DocumentMarkerController.cpp', u'Source/WebCore/dom/DocumentMarkerController.h', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/EventContext.cpp', u'Source/WebCore/dom/EventContext.h', u'Source/WebCore/dom/EventDispatcher.cpp', u'Source/WebCore/dom/EventNames.h', u'Source/WebCore/dom/EventNames.in', u'Source/WebCore/dom/MouseRelatedEvent.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/Position.h', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/dom/Range.h', u'Source/WebCore/dom/ScriptExecutionContext.cpp', u'Source/WebCore/dom/TreeScope.cpp', u'Source/WebCore/dom/ViewportArguments.cpp', u'Source/WebCore/dom/ViewportArguments.h', u'Source/WebCore/dom/make_names.pl', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/Settings.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/dom/EventNames.h:268:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/EventNames.h:271:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/EventNames.h:273:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/EventNames.h:277:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 David Kilzer (:ddkilzer) 2013-12-16 16:43:39 PST
Comment on attachment 219108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219108&action=review

r=me

> Source/WebCore/dom/DOMImplementation.cpp:352
> -#if ENABLE(VIDEO)
> +#if ENABLE(VIDEO) && !PLATFORM(IOS)

Would this be written better as:

#if ENABLE(VIDEO) && !ENABLE(PLUGIN_PROXY_FOR_VIDEO)
Comment 9 Daniel Bates 2013-12-16 17:29:04 PST
Committed r160679: <http://trac.webkit.org/changeset/160679>