Bug 125618 – Remove some unneeded code noticed while looking at StylePendingImage

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Darin Adler]

Remove some unneeded code noticed while looking at StylePendingImage

[Darin Adler]

Created attachment 219048 [details]
Patch

[WebKit Commit Bot]

Attachment 219048 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 219049 [details]
Patch

[Andreas Kling]

Comment on attachment 219049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219049&action=review

r=me

> Source/WebCore/css/StyleResolver.cpp:3881
> +    if (CSSImageValue* imageValue = pendingImage->cssImageValue())

auto

> Source/WebCore/css/StyleResolver.cpp:3884
> +    if (CSSImageGeneratorValue* imageGeneratorValue = pendingImage->cssImageGeneratorValue()) {

auto

> Source/WebCore/css/StyleResolver.cpp:3889
> +    if (CSSCursorImageValue* cursorImageValue = pendingImage->cssCursorImageValue())

auto

> Source/WebCore/css/StyleResolver.cpp:3893
> +    if (CSSImageSetValue* imageSetValue = pendingImage->cssImageSetValue())

auto

[Darin Adler]

Committed r160478: <http://trac.webkit.org/changeset/160478>