RESOLVED FIXED 125617
CStack Branch: Set stack pointer in OSR exit handler 
https://bugs.webkit.org/show_bug.cgi?id=125617
Summary CStack Branch: Set stack pointer in OSR exit handler
Michael Saboff
Reported 2013-12-11 22:32:30 PST
The stack pointer wasn't being set in OSR exit stub generator before jumping to the baseline JIT. It needs to be set just like at function entry.
Attachments
Patch (1.66 KB, patch)
2013-12-11 22:35 PST, Michael Saboff 		oliver: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (518.45 KB, application/zip)
2013-12-12 19:02 PST, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (433.43 KB, application/zip)
2013-12-13 18:31 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-12-11 22:35:13 PST
Created attachment 219044 [details] Patch
Michael Saboff
Comment 2 2013-12-11 22:37:55 PST
Landed in r160477 on the jsCStack branch: <http://trac.webkit.org/160477>
Build Bot
Comment 3 2013-12-12 19:02:51 PST
Comment on attachment 219044 [details] Patch Attachment 219044 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/48618036 New failing tests: cssom/cssvalue-comparison.html css3/flexbox/flex-algorithm-with-margins.html fast/canvas/webgl/arraybuffer-transfer-of-control.html css3/flexbox/columns-auto-size.html css3/flexbox/box-sizing.html fast/block/margin-collapse/self-collapsing-block-with-float-children.html editing/selection/move-by-word-visually-single-space-inline-element.html editing/execCommand/enabling-and-selection.html css3/flexbox/align-absolute-child.html http/tests/websocket/tests/hybi/frame-lengths.html fast/css/box-sizing-border-box-dynamic-padding-border-update.html fast/canvas/webgl/array-unit-tests.html fast/css-grid-layout/auto-content-resolution-columns.html editing/execCommand/enabling-and-selection-2.html css3/flexbox/columns-height-set-via-top-bottom.html editing/selection/move-by-word-visually-mac.html css3/flexbox/flex-algorithm-min-max.html fast/block/margins-perpendicular-containing-block.html css3/flexbox/auto-height-dynamic.html editing/selection/move-by-word-visually-multi-line.html fast/canvas/webgl/data-view-test.html editing/selection/select-bidi-run.html editing/selection/move-by-word-visually-single-space-one-element.html fast/canvas/canvas-longlived-context.html fast/canvas/getPutImageDataPairTest.html fast/block/dynamic-padding-border.html fast/block/shrink-to-fit-width-container-with-floating-children.html css3/flexbox/box-sizing-min-max-sizes.html fast/block/min-max-height-percent-height-child.html fast/css/css-selector-deeply-nested.html
Build Bot
Comment 4 2013-12-12 19:02:52 PST
Created attachment 219140 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 5 2013-12-13 18:31:32 PST
Comment on attachment 219044 [details] Patch Attachment 219044 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/47378002 New failing tests: cssom/cssvalue-comparison.html fast/block/shrink-to-fit-width-container-with-floating-children.html css3/flexbox/columns-auto-size.html css3/flexbox/box-sizing.html fast/block/margin-collapse/self-collapsing-block-with-float-children.html editing/selection/move-by-word-visually-single-space-inline-element.html editing/execCommand/enabling-and-selection.html fast/css-intrinsic-dimensions/css-tables.html css3/flexbox/align-absolute-child.html fast/css/box-sizing-border-box-dynamic-padding-border-update.html fast/canvas/webgl/array-unit-tests.html fast/css-grid-layout/auto-content-resolution-columns.html editing/execCommand/enabling-and-selection-2.html css3/flexbox/columns-height-set-via-top-bottom.html editing/selection/move-by-word-visually-mac.html css3/flexbox/flex-algorithm-min-max.html fast/block/margins-perpendicular-containing-block.html fast/canvas/webgl/gl-vertexattribpointer.html css3/flexbox/auto-height-dynamic.html fast/block/min-max-height-percent-height-child.html editing/selection/move-by-word-visually-multi-line.html fast/canvas/webgl/data-view-test.html fast/css-grid-layout/auto-content-resolution-rows.html fast/canvas/canvas-longlived-context.html fast/canvas/getPutImageDataPairTest.html fast/block/dynamic-padding-border.html fast/canvas/webgl/arraybuffer-transfer-of-control.html css3/flexbox/box-sizing-min-max-sizes.html fast/css/deprecated-flexbox-auto-min-size.html fast/css/css-selector-deeply-nested.html
Build Bot
Comment 6 2013-12-13 18:31:34 PST
Created attachment 219217 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Mark Lam
Comment 7 2014-01-13 18:45:15 PST
Review status updated in r161938: <http://trac.webkit.org/r161938>.
Note You need to log in before you can comment on or make changes to this bug.