Bug 125609 - jsCStack: Introducing MaxFrameExtentForSlowPathCall.h
Summary: jsCStack: Introducing MaxFrameExtentForSlowPathCall.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-11 18:07 PST by Mark Lam
Modified: 2013-12-11 18:21 PST (History)
5 users (show)

See Also:

Attachments
the patch. (3.93 KB, patch)
2013-12-11 18:11 PST, Mark Lam 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-12-11 18:07:48 PST 
Depending on the target CPU architecture / ABI, we need to allocate some amount of stack space for holding outgoing args for slow path calls from JS to C functions.   MaxFrameExtentForSlowPathCall.h will define this constant.
Comment 1 Mark Lam 2013-12-11 18:11:10 PST 
Created attachment 219025 [details]
the patch.
Comment 2 Mark Hahnenberg 2013-12-11 18:18:06 PST 
Comment on attachment 219025 [details]
the patch.

r=me. We might want to create file for all globals eventually, but this will work for now.
Comment 3 Mark Hahnenberg 2013-12-11 18:18:20 PST 
(In reply to comment #2)
> (From update of attachment 219025 [details])
> r=me. We might want to create file for all globals eventually, but this will work for now.

And by globals I mean global constants.
Comment 4 Mark Lam 2013-12-11 18:21:02 PST 
Landed in r160470 on the jsCStack branch: <http://trac.webkit.org/r160470>