Bug 125602 - Cache getters and custom accessors on the prototype chain
Summary: Cache getters and custom accessors on the prototype chain
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-11 14:18 PST by Oliver Hunt
Modified: 2013-12-17 10:09 PST (History)
3 users (show)

See Also:


Attachments
Patch (18.59 KB, patch)
2013-12-11 14:25 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (585.59 KB, application/zip)
2013-12-11 15:26 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (641.62 KB, application/zip)
2013-12-12 18:00 PST, Build Bot
no flags Details
Patch (26.37 KB, patch)
2013-12-13 14:27 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (26.66 KB, patch)
2013-12-13 14:31 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (750.27 KB, application/zip)
2013-12-14 09:44 PST, Build Bot
no flags Details
Patch (31.28 KB, patch)
2013-12-16 14:48 PST, Oliver Hunt
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-12-11 14:18:29 PST
Cache getters and custom accessors on the prototype chain
Comment 1 Oliver Hunt 2013-12-11 14:25:40 PST
Created attachment 219003 [details]
Patch
Comment 2 Oliver Hunt 2013-12-11 14:27:22 PST
Comment on attachment 219003 [details]
Patch

this is still failing tests.
Comment 3 Build Bot 2013-12-11 15:26:10 PST
Comment on attachment 219003 [details]
Patch

Attachment 219003 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/48138054

New failing tests:
js/regress/basic-set.html
css3/compositing/background-blend-mode-property-parsing.html
css3/filters/custom/custom-filter-property-computed-style.html
inspector-protocol/model/content-flow-content-removal.html
editing/unsupported-content/table-type-before.html
media/video-display-aspect-ratio.html
css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid.html
js/dom/typed-array-set-different-types.html
fast/canvas/webgl/uninitialized-test.html
editing/unsupported-content/list-type-before.html
css3/filters/custom/custom-filter-property-parsing.html
css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html
css3/filters/filter-property-parsing.html
css3/compositing/blend-mode-property-parsing.html
editing/unsupported-content/table-delete-002.html
editing/unsupported-content/list-delete-001.html
fast/dom/prototype-chain.html
css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html
css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html
js/regress/HashMap-put-get-iterate.html
fast/canvas/webgl/oes-texture-float-linear.html
js/regress/HashMap-string-put-get-iterate.html
css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid.html
fast/dom/wrapper-classes.html
fast/canvas/webgl/premultiplyalpha-test.html
css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html
editing/unsupported-content/list-delete-003.html
editing/unsupported-content/list-type-after.html
editing/unsupported-content/table-type-after.html
inspector-protocol/model/content-flow-content-nodes.html
Comment 4 Build Bot 2013-12-11 15:26:11 PST
Created attachment 219008 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2013-12-12 18:00:27 PST
Comment on attachment 219003 [details]
Patch

Attachment 219003 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/48618022

New failing tests:
webgl/1.0.1/conformance/renderbuffers/renderbuffer-initialization.html
css3/compositing/background-blend-mode-property-parsing.html
js/regress/basic-set.html
css3/filters/custom/custom-filter-property-computed-style.html
inspector-protocol/model/content-flow-content-removal.html
inspector-protocol/model/content-node-region-info.html
fast/dom/prototype-chain.html
webgl/1.0.1/conformance/misc/uninitialized-test.html
fast/canvas/webgl/uninitialized-test.html
css3/filters/custom/custom-filter-property-parsing.html
css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html
inspector-protocol/model/main-frame-resource.html
css3/filters/filter-property-parsing.html
css3/compositing/blend-mode-property-parsing.html
inspector-protocol/model/content-flow-list.html
css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html
css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html
js/regress/HashMap-put-get-iterate.html
fast/canvas/webgl/oes-texture-float-linear.html
js/regress/HashMap-string-put-get-iterate.html
webgl/1.0.1/conformance/glsl/samplers/glsl-function-texture2d-bias.html
webgl/1.0.2/conformance/misc/uninitialized-test.html
css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid.html
fast/dom/wrapper-classes.html
fast/canvas/webgl/premultiplyalpha-test.html
css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html
css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid.html
webgl/1.0.1/conformance/context/premultiplyalpha-test.html
js/dom/typed-array-set-different-types.html
inspector-protocol/model/content-flow-content-nodes.html
Comment 6 Build Bot 2013-12-12 18:00:29 PST
Created attachment 219138 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Oliver Hunt 2013-12-13 14:27:49 PST
Created attachment 219198 [details]
Patch
Comment 8 Oliver Hunt 2013-12-13 14:31:32 PST
Created attachment 219200 [details]
Patch
Comment 9 Build Bot 2013-12-14 09:44:30 PST
Comment on attachment 219200 [details]
Patch

Attachment 219200 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/44838401

New failing tests:
webgl/1.0.1/conformance/renderbuffers/renderbuffer-initialization.html
webgl/1.0.2/conformance/ogles/GL/equal/equal_001_to_008.html
fast/canvas/webgl/uninitialized-test.html
media/video-display-aspect-ratio.html
webgl/1.0.2/conformance/ogles/GL/ceil/ceil_001_to_006.html
webgl/1.0.2/conformance/ogles/GL/asin/asin_001_to_006.html
webgl/1.0.2/conformance/glsl/samplers/glsl-function-texture2dlod.html
webgl/1.0.2/conformance/glsl/samplers/glsl-function-texture2d-bias.html
webgl/1.0.2/conformance/ogles/GL/acos/acos_001_to_006.html
webgl/1.0.2/conformance/ogles/GL/degrees/degrees_001_to_006.html
webgl/1.0.2/conformance/extensions/oes-texture-float.html
webgl/1.0.2/conformance/canvas/drawingbuffer-hd-dpi-test.html
webgl/1.0.2/conformance/context/premultiplyalpha-test.html
webgl/1.0.2/conformance/ogles/GL/cos/cos_001_to_006.html
webgl/1.0.2/conformance/glsl/misc/shader-with-short-circuiting-operators.html
js/regress/HashMap-put-get-iterate.html
webgl/1.0.2/conformance/ogles/GL/abs/abs_001_to_006.html
js/regress/HashMap-string-put-get-iterate.html
webgl/1.0.2/conformance/ogles/GL/distance/distance_001_to_006.html
webgl/1.0.1/conformance/glsl/samplers/glsl-function-texture2d-bias.html
webgl/1.0.2/conformance/ogles/GL/dot/dot_001_to_006.html
webgl/1.0.2/conformance/ogles/GL/atan/atan_009_to_012.html
webgl/1.0.2/conformance/misc/uninitialized-test.html
webgl/1.0.1/conformance/misc/uninitialized-test.html
webgl/1.0.2/conformance/ogles/GL/biConstants/biConstants_001_to_008.html
fast/canvas/webgl/premultiplyalpha-test.html
webgl/1.0.2/conformance/ogles/GL/clamp/clamp_001_to_006.html
fast/canvas/webgl/oes-texture-float-linear.html
webgl/1.0.1/conformance/context/premultiplyalpha-test.html
webgl/1.0.2/conformance/ogles/GL/biConstants/biConstants_009_to_016.html
Comment 10 Build Bot 2013-12-14 09:44:32 PST
Created attachment 219252 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 11 Oliver Hunt 2013-12-16 14:48:20 PST
Created attachment 219356 [details]
Patch
Comment 12 Oliver Hunt 2013-12-16 15:57:47 PST
Committed r160670: <http://trac.webkit.org/changeset/160670>
Comment 13 Geoffrey Garen 2013-12-16 21:55:13 PST
What about all the "New failing tests"?
Comment 14 Oliver Hunt 2013-12-17 10:09:21 PST
(In reply to comment #13)
> What about all the "New failing tests"?

They weren't failing in the final checkin, those failing tests were in WIP patches