WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125598
Give Unique StringImpls a meaningful data pointer
https://bugs.webkit.org/show_bug.cgi?id=125598
Summary
Give Unique StringImpls a meaningful data pointer
Oliver Hunt
Reported
2013-12-11 13:44:32 PST
Give Unique StringImpls a meaningful data pointer
Attachments
Patch
(1.78 KB, patch)
2013-12-11 13:48 PST
,
Oliver Hunt
msaboff
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2013-12-11 13:48:13 PST
Created
attachment 219000
[details]
Patch
Michael Saboff
Comment 2
2013-12-11 13:52:44 PST
Comment on
attachment 219000
[details]
Patch r=me, but add a comment in the code that we expect m_buffer to be null. If we change StringImpl in the future it will be easier to see why you're doing this without tracking down the change set / bug.
Oliver Hunt
Comment 3
2013-12-11 14:04:08 PST
Committed
r160453
: <
http://trac.webkit.org/changeset/160453
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug