Bug 125598 - Give Unique StringImpls a meaningful data pointer
Summary: Give Unique StringImpls a meaningful data pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-11 13:44 PST by Oliver Hunt
Modified: 2013-12-11 14:04 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2013-12-11 13:48 PST, Oliver Hunt 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-12-11 13:44:32 PST 
Give Unique StringImpls a meaningful data pointer
Comment 1 Oliver Hunt 2013-12-11 13:48:13 PST 
Created attachment 219000 [details]
Patch
Comment 2 Michael Saboff 2013-12-11 13:52:44 PST 
Comment on attachment 219000 [details]
Patch

r=me, but add a comment in the code that we expect m_buffer to be null.  If we change StringImpl in the future it will be easier to see why you're doing this without tracking down the change set / bug.
Comment 3 Oliver Hunt 2013-12-11 14:04:08 PST 
Committed r160453: <http://trac.webkit.org/changeset/160453>