RESOLVED FIXED 125590
WebCrypto keys should support structured clone 
https://bugs.webkit.org/show_bug.cgi?id=125590
Summary WebCrypto keys should support structured clone
Alexey Proskuryakov
Reported 2013-12-11 11:21:46 PST
WebCrypto keys should support structured clone.
Attachments
proposed patch (53.76 KB, patch)
2013-12-11 11:39 PST, Alexey Proskuryakov 		oliver: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
with build fixes (55.55 KB, patch)
2013-12-11 11:59 PST, Alexey Proskuryakov 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-12-11 11:39:39 PST
Created attachment 218987 [details] proposed patch
WebKit Commit Bot
Comment 2 2013-12-11 11:41:35 PST
Attachment 218987 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/crypto/subtle/aes-postMessage-expected.txt', u'LayoutTests/crypto/subtle/aes-postMessage.html', u'LayoutTests/crypto/subtle/hmac-postMessage-expected.txt', u'LayoutTests/crypto/subtle/hmac-postMessage.html', u'LayoutTests/crypto/subtle/postMessage-worker-expected.txt', u'LayoutTests/crypto/subtle/postMessage-worker.html', u'LayoutTests/crypto/subtle/resources/postMessage-worker.js', u'LayoutTests/crypto/subtle/rsa-postMessage-expected.txt', u'LayoutTests/crypto/subtle/rsa-postMessage.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/crypto/CryptoAlgorithmIdentifier.h', u'Source/WebCore/crypto/CryptoAlgorithmRegistry.cpp', u'Source/WebCore/crypto/CryptoKey.idl', u'Source/WebCore/crypto/keys/CryptoKeyAES.cpp', u'Source/WebCore/crypto/keys/CryptoKeyAES.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:171: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:172: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:173: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:198: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:199: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:200: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:201: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:202: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:203: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:204: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:205: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:206: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:207: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:208: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:209: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:210: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:211: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:212: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:213: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:214: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:215: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:216: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:217: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/crypto/CryptoAlgorithmIdentifier.h:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/crypto/CryptoAlgorithmIdentifier.h:55: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 25 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 3 2013-12-11 11:44:38 PST
Comment on attachment 218987 [details] proposed patch Attachment 218987 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/48018016
EFL EWS Bot
Comment 4 2013-12-11 11:45:44 PST
Comment on attachment 218987 [details] proposed patch Attachment 218987 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/48028020
Alexey Proskuryakov
Comment 5 2013-12-11 11:59:30 PST
Created attachment 218992 [details] with build fixes
WebKit Commit Bot
Comment 6 2013-12-11 12:01:54 PST
Attachment 218992 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/crypto/subtle/aes-postMessage-expected.txt', u'LayoutTests/crypto/subtle/aes-postMessage.html', u'LayoutTests/crypto/subtle/hmac-postMessage-expected.txt', u'LayoutTests/crypto/subtle/hmac-postMessage.html', u'LayoutTests/crypto/subtle/postMessage-worker-expected.txt', u'LayoutTests/crypto/subtle/postMessage-worker.html', u'LayoutTests/crypto/subtle/resources/postMessage-worker.js', u'LayoutTests/crypto/subtle/rsa-postMessage-expected.txt', u'LayoutTests/crypto/subtle/rsa-postMessage.html', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/crypto/CryptoAlgorithmIdentifier.h', u'Source/WebCore/crypto/CryptoAlgorithmRegistry.cpp', u'Source/WebCore/crypto/CryptoKey.idl', u'Source/WebCore/crypto/keys/CryptoKeyAES.cpp', u'Source/WebCore/crypto/keys/CryptoKeyAES.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:171: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:172: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:173: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:198: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:199: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:200: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:201: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:202: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:203: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:204: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:205: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:206: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:207: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:208: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:209: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:210: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:211: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:212: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:213: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:214: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:215: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:216: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:217: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/crypto/CryptoAlgorithmIdentifier.h:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/crypto/CryptoAlgorithmIdentifier.h:55: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 25 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 7 2013-12-11 12:29:53 PST
Comment on attachment 218992 [details] with build fixes Attachment 218992 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/48098006
Alexey Proskuryakov
Comment 8 2013-12-11 14:11:09 PST
Committed <http://trac.webkit.org/r160455> with ab additional Windows build fix.
Note You need to log in before you can comment on or make changes to this bug.