This would include things such as: * <div role="article"> * <article>
Created attachment 218983 [details] Patch proposal
Comment on attachment 218983 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=218983&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:651 > +#if ATK_CHECK_VERSION(2, 11, 3) Do you need this version check, since you updated the dependency already?
(In reply to comment #2) > (From update of attachment 218983 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218983&action=review > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:651 > > +#if ATK_CHECK_VERSION(2, 11, 3) > > Do you need this version check, since you updated the dependency already? Yes, I need it because I updated the version of the package in the internal jhbuild system, but that is only used for development or testing (e.g. the buildbots). However, people will still be able to build WebKitGTK+ with former versions of ATK (from 2.8.0 on), which do not contain that role, so we need the check
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 218983 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=218983&action=review > > > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:651 > > > +#if ATK_CHECK_VERSION(2, 11, 3) > > > > Do you need this version check, since you updated the dependency already? > > Yes, I need it because I updated the version of the package in the internal jhbuild system, but that is only used for development or testing (e.g. the buildbots). However, people will still be able to build WebKitGTK+ with former versions of ATK (from 2.8.0 on), which do not contain that role, so we need the check So should you maintain an #if #else #endif scenario so that those older builders will get the old behavior?
Comment on attachment 218983 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=218983&action=review >>>> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:651 >>>> +#if ATK_CHECK_VERSION(2, 11, 3) >>> >>> Do you need this version check, since you updated the dependency already? >> >> Yes, I need it because I updated the version of the package in the internal jhbuild system, but that is only used for development or testing (e.g. the buildbots). However, people will still be able to build WebKitGTK+ with former versions of ATK (from 2.8.0 on), which do not contain that role, so we need the check > > So should you maintain an > > #if > #else > #endif > > scenario so that those older builders will get the old behavior? That's what is already happening with this patch already now. Old builders will see: case DocumentArticleRole: case DocumentRole: return ATK_ROLE_DOCUMENT_FRAME; Which is the same behaviour they saw before, just with the case staments swapped
Committed r160637: <http://trac.webkit.org/changeset/160637>