Bug 125584 – [ATK] Expose accessibility objects WAI-ARIA landmark roles

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Mario Sanchez Prada]

This includes:

 * <address>
 * <aside>
 * <header>
 * <nav>
 * <div role="banner">
 * <div role="complementary">
 * <div role="contentinfo">
 * <div role="main">
 * <div role="navigation">
 * <div role="search">

[Mario Sanchez Prada]

Created attachment 218977 [details]
Patch proposal

[chris fleizach]

Comment on attachment 218977 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=218977&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:534
> +    if (role == LandmarkBannerRole)

we should use a switch statement here

> Tools/gtk/jhbuild.modules:235
> +    <branch module="pub/GNOME/sources/atk/2.11/atk-2.11.3.tar.xz" version="2.11.3"

seems like this should be in a different patch

[Mario Sanchez Prada]

(In reply to comment #2)
> (From update of attachment 218977 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218977&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:534
> > +    if (role == LandmarkBannerRole)
> 
> we should use a switch statement here

Ok

> > Tools/gtk/jhbuild.modules:235
> > +    <branch module="pub/GNOME/sources/atk/2.11/atk-2.11.3.tar.xz" version="2.11.3"
> 
> seems like this should be in a different patch

I think it's better to have it in this one, since we need to bump that new version in the jhbuild because of this patch

[Mario Sanchez Prada]

Created attachment 218986 [details]
Patch proposal

New patch with the switch statement

[chris fleizach]

Comment on attachment 218986 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=218986&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:532
> +    // of LandMarkApplicationRole, whic will be exposed with ATK_ROLE_EMBEDDED.

should be LandmarkApplicationRole

which spelled wrong

[Mario Sanchez Prada]

(In reply to comment #5)
> (From update of attachment 218986 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218986&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:532
> > +    // of LandMarkApplicationRole, whic will be exposed with ATK_ROLE_EMBEDDED.
> 
> should be LandmarkApplicationRole
> 
> which spelled wrong

I'll fix it before landing. Thanks

[Mario Sanchez Prada]

Committed r160450: <http://trac.webkit.org/changeset/160450>