Bug 125584 - [ATK] Expose accessibility objects WAI-ARIA landmark roles
Summary: [ATK] Expose accessibility objects WAI-ARIA landmark roles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 125493
  Show dependency treegraph
 
Reported: 2013-12-11 10:44 PST by Mario Sanchez Prada
Modified: 2013-12-11 11:46 PST (History)
9 users (show)

See Also:


Attachments
Patch proposal (20.60 KB, patch)
2013-12-11 10:55 PST, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff
Patch proposal (20.69 KB, patch)
2013-12-11 11:36 PST, Mario Sanchez Prada
cfleizach: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2013-12-11 10:44:46 PST
This includes:

 * <address>
 * <aside>
 * <header>
 * <nav>
 * <div role="banner">
 * <div role="complementary">
 * <div role="contentinfo">
 * <div role="main">
 * <div role="navigation">
 * <div role="search">
Comment 1 Mario Sanchez Prada 2013-12-11 10:55:36 PST
Created attachment 218977 [details]
Patch proposal
Comment 2 chris fleizach 2013-12-11 11:20:52 PST
Comment on attachment 218977 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=218977&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:534
> +    if (role == LandmarkBannerRole)

we should use a switch statement here

> Tools/gtk/jhbuild.modules:235
> +    <branch module="pub/GNOME/sources/atk/2.11/atk-2.11.3.tar.xz" version="2.11.3"

seems like this should be in a different patch
Comment 3 Mario Sanchez Prada 2013-12-11 11:26:46 PST
(In reply to comment #2)
> (From update of attachment 218977 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218977&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:534
> > +    if (role == LandmarkBannerRole)
> 
> we should use a switch statement here

Ok

> > Tools/gtk/jhbuild.modules:235
> > +    <branch module="pub/GNOME/sources/atk/2.11/atk-2.11.3.tar.xz" version="2.11.3"
> 
> seems like this should be in a different patch

I think it's better to have it in this one, since we need to bump that new version in the jhbuild because of this patch
Comment 4 Mario Sanchez Prada 2013-12-11 11:36:58 PST
Created attachment 218986 [details]
Patch proposal

New patch with the switch statement
Comment 5 chris fleizach 2013-12-11 11:39:33 PST
Comment on attachment 218986 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=218986&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:532
> +    // of LandMarkApplicationRole, whic will be exposed with ATK_ROLE_EMBEDDED.

should be LandmarkApplicationRole

which spelled wrong
Comment 6 Mario Sanchez Prada 2013-12-11 11:42:01 PST
(In reply to comment #5)
> (From update of attachment 218986 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218986&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:532
> > +    // of LandMarkApplicationRole, whic will be exposed with ATK_ROLE_EMBEDDED.
> 
> should be LandmarkApplicationRole
> 
> which spelled wrong

I'll fix it before landing. Thanks
Comment 7 Mario Sanchez Prada 2013-12-11 11:46:52 PST
Committed r160450: <http://trac.webkit.org/changeset/160450>