Bug 125574 – Adding RTCPeerConnectionErrorCallback

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Thiago de Barros Lacerda]

According to the spec there should be a RTCPeerConnectionErrorCallback function type for createOffer/Answer, setLocal/RemoteDescription and updateIce function calls.
This callback must handle a DOMError object.

[Thiago de Barros Lacerda]

Created attachment 218967 [details]
Patch

[Philippe Normand]

Comment on attachment 218967 [details]
Patch

Seems like this is not rebased on top of ToT ?

[Philippe Normand]

Looks good otherwise

[Thiago de Barros Lacerda]

(In reply to comment #3)
> Looks good otherwise

Hey Philippe, that's because it depends on https://bugs.webkit.org/show_bug.cgi?id=125568.
Could you take a look on it as well?

[Thiago de Barros Lacerda]

Created attachment 218968 [details]
Patch

[Build Bot]

Comment on attachment 218968 [details]
Patch

Attachment 218968 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/47308534

[Philippe Normand]

Created attachment 218972 [details]
Patch

with Xcode project update

[Philippe Normand]

Comment on attachment 218968 [details]
Patch

Didn't pass mac EWS

[Build Bot]

Comment on attachment 218972 [details]
Patch

Attachment 218972 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/47348348

[Build Bot]

Comment on attachment 218972 [details]
Patch

Attachment 218972 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/47208575

[Build Bot]

Comment on attachment 218972 [details]
Patch

Attachment 218972 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/45888560

[Philippe Normand]

Created attachment 218978 [details]
Patch

[Build Bot]

Comment on attachment 218978 [details]
Patch

Attachment 218978 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/47438176

[Build Bot]

Comment on attachment 218978 [details]
Patch

Attachment 218978 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/45658027

[Build Bot]

Comment on attachment 218978 [details]
Patch

Attachment 218978 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/47008146

[Eric Carlson]

Comment on attachment 218978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218978&action=review

> LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html:26
>                  errorReason = reason;
> -                shouldBe('errorReason', '"TEST_ERROR"');
> +                shouldBe('errorReason.name', '"IncompatibleConstraintsError"');

Is it possible to create tests for the other new errors?

[Philippe Normand]

Created attachment 219069 [details]
Patch

with Xcode project update

[Thiago de Barros Lacerda]

(In reply to comment #16)
> (From update of attachment 218978 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218978&action=review
> 
> > LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html:26
> >                  errorReason = reason;
> > -                shouldBe('errorReason', '"TEST_ERROR"');
> > +                shouldBe('errorReason.name', '"IncompatibleConstraintsError"');
> 
> Is it possible to create tests for the other new errors?

Yes Eric, I'm now working on a patch for them. I didn't not put on this because it would increase the size of the patch too much. Are you OK with another patch?

[Eric Carlson]

(In reply to comment #18)
> (In reply to comment #16)
> > (From update of attachment 218978 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=218978&action=review
> > 
> > > LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html:26
> > >                  errorReason = reason;
> > > -                shouldBe('errorReason', '"TEST_ERROR"');
> > > +                shouldBe('errorReason.name', '"IncompatibleConstraintsError"');
> > 
> > Is it possible to create tests for the other new errors?
> 
> Yes Eric, I'm now working on a patch for them. I didn't not put on this because it would increase the size of the patch too much. Are you OK with another patch?

That seems fine. Please include a FIXME: with a bug number so someone reading the patch knows what the plan is.

[Thiago de Barros Lacerda]

Created attachment 219113 [details]
Patch

[Philippe Normand]

Seems like  a FIXME is missing or we assume it's the bug blocked by this one?

[Thiago de Barros Lacerda]

(In reply to comment #21)
> Seems like  a FIXME is missing or we assume it's the bug blocked by this one?

It's the bug blocked by this one

[WebKit Commit Bot]

Comment on attachment 219113 [details]
Patch

Clearing flags on attachment: 219113

Committed r160553: <http://trac.webkit.org/changeset/160553>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.