Bug 125570 - Move ChildProcessProxy from Shared to UIProcess
Summary: Move ChildProcessProxy from Shared to UIProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-11 06:11 PST by Carlos Garcia Campos
Modified: 2016-01-12 09:23 PST (History)
11 users (show)

See Also:

Attachments
Patch (26.27 KB, patch)
2013-12-11 06:12 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Rebased patch (28.39 KB, patch)
2016-01-12 03:58 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-12-11 06:11:11 PST 
It's only used by UIProcess.
Comment 1 Carlos Garcia Campos 2013-12-11 06:12:54 PST 
Created attachment 218955 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-11 06:14:49 PST 
Attachment 218955 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.list.am', u'Source/WebKit2/Shared/ChildProcessProxy.cpp', u'Source/WebKit2/Shared/ChildProcessProxy.h', u'Source/WebKit2/UIProcess/ChildProcessProxy.cpp', u'Source/WebKit2/UIProcess/ChildProcessProxy.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/UIProcess/ChildProcessProxy.h:51:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Catanzaro 2016-01-02 09:12:29 PST 
Owners?
Comment 4 Darin Adler 2016-01-11 08:45:22 PST 
Seems OK to me. But can you upload a patch that applies and builds?
Comment 5 Carlos Garcia Campos 2016-01-11 10:05:33 PST 
Sure, I'll prepare a new patch
Comment 6 Carlos Garcia Campos 2016-01-12 03:58:46 PST 
Created attachment 268756 [details]
Rebased patch
Comment 7 WebKit Commit Bot 2016-01-12 09:23:42 PST 
Comment on attachment 268756 [details]
Rebased patch

Clearing flags on attachment: 268756

Committed r194895: <http://trac.webkit.org/changeset/194895>
Comment 8 WebKit Commit Bot 2016-01-12 09:23:49 PST 
All reviewed patches have been landed.  Closing bug.