Bug 125564 – [WK2][SOUP] WebContext::allowSpecificHTTPSCertificateForHost does not work correctly when m_usesNetworkProcess is false

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Kwang Yul Seo]

WebContext::allowSpecificHTTPSCertificateForHost should send AllowSpecificHTTPSCertificateForHost to the web process when m_usesNetworkProcess is false. Also we shouldn't guard WebProcess::allowSpecificHTTPSCertificateForHost with !ENABLE(NETWORK_PROCESS) because we need this method when m_usesNetworkProcess is false.

[Kwang Yul Seo]

Created attachment 218944 [details]
Patch

[Carlos Garcia Campos]

Right, SSL errors are broken when building with network process but not using it.

$ Programs/WebKit2APITests/TestSSL
/webkit2/WebKitWebView/ssl: OK
/webkit2/WebKitWebView/insecure-content: OK
/webkit2/WebKitWebView/tls-errors-policy: OK
/webkit2/WebKitWebView/load-failed-with-tls-errors: **
ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp:210:void testLoadFailedWithTLSErrors(TLSErrorsTest*, gconstpointer): assertion failed (test->m_loadEvents[1] == LoadTrackingTest::LoadCommitted): (4 == 3)

$ WEBKIT_USE_NETWORK_PROCESS=1 jrun Programs/WebKit2APITests/TestSSL
/webkit2/WebKitWebView/ssl: OK
/webkit2/WebKitWebView/insecure-content: OK
/webkit2/WebKitWebView/tls-errors-policy: OK
/webkit2/WebKitWebView/load-failed-with-tls-errors: OK

[Carlos Garcia Campos]

Comment on attachment 218944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218944&action=review

Thanks!

> Source/WebKit2/WebProcess/WebProcess.h:60
> -#if !ENABLE(NETWORK_PROCESS) && USE(SOUP)
> +#if USE(SOUP)
>  class CertificateInfo;
>  #endif

This change is no longer required, and probably the reason why the patch didn't apply.

[Carlos Garcia Campos]

Created attachment 219868 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 219868 [details]
Patch for landing

Clearing flags on attachment: 219868

Committed r160986: <http://trac.webkit.org/changeset/160986>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.