SVG text has to handle xml:space="preserve". And SVG text is never allowed to contain tabs. Fixing that will fix some W3C-SVG-1.1 included tests. Attaching patch.
Created attachment 12896 [details] Initial patch This contains some RenderStyle.h changes - I'd feel good if maybe Hyatt/Maciej can have a look here, too.
Comment on attachment 12896 [details] Initial patch This new SVG_PRE value should not be in the SVG-specific files nor should it be ifdef'd. How exactly is SVG_PRE different from PRE_WRAP? + // SVG text never contains tabs! Are you sure this is the best way to do this? We specifically don't do this to change '\n' characters into ' ' characters. Definitely should discuss these changes with Hyatt. Given the number of different places changed, I want to see a separate test for each one. Basically if I take out any one of the SVG_PRE checks, a test should fail. We need to construct those tests.
(In reply to comment #2) > (From update of attachment 12896 [details] [edit]) > This new SVG_PRE value should not be in the SVG-specific files nor should it be > ifdef'd. > > How exactly is SVG_PRE different from PRE_WRAP? > > + // SVG text never contains tabs! > > Are you sure this is the best way to do this? We specifically don't do this to > change '\n' characters into ' ' characters. I had a chat with Mitz & Sam about these things and it turns out there is a much less intrusive possiblity to handle xml:space correctly, attaching new patch soon. Niko
Created attachment 12906 [details] Updated patch Includes a new layout test testing all specified (SVG 1.1 spec) whitespace handling possibilities.
Comment on attachment 12906 [details] Updated patch With the one change we discussed in IRC, r=me.
Landed in r19390.