Bug 125541 - [WebGL] Fix build on GL ES 2.0 targets after r160119
Summary: [WebGL] Fix build on GL ES 2.0 targets after r160119
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 125293 (view as bug list)
Depends on: 110936
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-10 13:30 PST by Ralph T
Modified: 2013-12-16 21:53 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2013-12-10 13:32 PST, Ralph T 		no flags Details | Formatted Diff | Diff
Patch (2.56 KB, patch)
2013-12-11 13:11 PST, Ralph T 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph T 2013-12-10 13:30:43 PST 
[WebGL] Fix build on GL ES 2.0 targets after r160119
Comment 1 Ralph T 2013-12-10 13:32:15 PST 
Created attachment 218903 [details]
Patch
Comment 2 Ralph T 2013-12-10 13:35:38 PST 
This is needed to fix compilation on GL ES 2.0 targets. I haven't tested half float functionality through WebGL on any GL ES 2.0 devices yet, though.
Comment 3 Alex Christensen 2013-12-11 12:53:34 PST 
I proposed the same solution in https://bugs.webkit.org/show_bug.cgi?id=125464 but peavo got to it before I did.  Should r160119 be removed and this be added in the same patch?
Comment 4 Alex Christensen 2013-12-11 12:55:42 PST 
I mean should r160324 be removed and this be added in the same patch? r160119 is ok except for this little quirk.
Comment 5 Ralph T 2013-12-11 12:57:42 PST 
(In reply to comment #4)
> I mean should r160324 be removed and this be added in the same patch? r160119 is ok except for this little quirk.

Yes, I think so. Let me see if I can do that.
Comment 6 Ralph T 2013-12-11 13:11:11 PST 
Created attachment 218997 [details]
Patch
Comment 7 Alex Christensen 2013-12-11 14:09:51 PST 
Looks good to me.  There's a reason that's not defined in our GLES headers, and it fixes the compiling error.  I'm not a reviewer yet, though...
Comment 8 Brent Fulgham 2013-12-11 14:19:39 PST 
Comment on attachment 218997 [details]
Patch

Looks good to me.  r=me
Comment 9 WebKit Commit Bot 2013-12-11 14:43:44 PST 
Comment on attachment 218997 [details]
Patch

Clearing flags on attachment: 218997

Committed r160458: <http://trac.webkit.org/changeset/160458>
Comment 10 WebKit Commit Bot 2013-12-11 14:43:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 ChangSeok Oh 2013-12-16 21:53:16 PST 
*** Bug 125293 has been marked as a duplicate of this bug. ***