Bug 125538 - Simplify CSE's treatment of NodeRelevantToOSR
Summary: Simplify CSE's treatment of NodeRelevantToOSR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-10 13:14 PST by Filip Pizlo
Modified: 2013-12-10 18:07 PST (History)
8 users (show)

See Also:

Attachments
the patch (4.43 KB, patch)
2013-12-10 13:16 PST, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-12-10 13:14:12 PST 
CSE does a simplification over Phantoms based on whether the source of the Phantom is relevant to OSR.  It does this in a way that totally makes sense if node references are block-local, and I can sort of convince myself that it kind of ought to sort of work for SSA, but it's confusing in its current form.  We should simplify this so that it obviously works: if there is any MovHint on a node then the node is relevant to OSR.
Comment 1 Filip Pizlo 2013-12-10 13:16:03 PST 
Created attachment 218900 [details]
the patch
Comment 2 Filip Pizlo 2013-12-10 18:07:56 PST 
Landed in http://trac.webkit.org/changeset/160407