WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125512
[GTK][CMake] make libjavascriptcoregtk a public shared library again
https://bugs.webkit.org/show_bug.cgi?id=125512
Summary
[GTK][CMake] make libjavascriptcoregtk a public shared library again
Gustavo Noronha (kov)
Reported
2013-12-10 07:17:52 PST
Right now JSC is being built as an intermediate static library, we need to support shipping it as a shared library.
Attachments
Patch
(4.56 KB, patch)
2013-12-18 13:38 PST
,
Gustavo Noronha (kov)
no flags
Details
Formatted Diff
Diff
Patch
(3.77 KB, patch)
2013-12-18 14:56 PST
,
Gustavo Noronha (kov)
mrobinson
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1
2013-12-18 13:38:13 PST
Created
attachment 219563
[details]
Patch
EFL EWS Bot
Comment 2
2013-12-18 14:30:01 PST
Comment on
attachment 219563
[details]
Patch
Attachment 219563
[details]
did not pass efl-wk2-ews (efl-wk2): Output:
http://webkit-queues.appspot.com/results/50478068
Gustavo Noronha (kov)
Comment 3
2013-12-18 14:56:15 PST
Created
attachment 219574
[details]
Patch
Martin Robinson
Comment 4
2013-12-18 15:10:11 PST
Comment on
attachment 219574
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=219574&action=review
> Source/JavaScriptCore/CMakeLists.txt:765 > +get_target_property(TARGET_TYPE JavaScriptCore TYPE) > +if (${TARGET_TYPE} STREQUAL "SHARED_LIBRARY")
I think you can just do: if (${JavaScriptCore_LIBRARY_TYPE} STREQUAL "SHARED") here and avoid the get_target_property call.
Gustavo Noronha (kov)
Comment 5
2013-12-18 17:31:54 PST
Committed
r160812
: <
http://trac.webkit.org/changeset/160812
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug