Bug 125509 - Use std::array when computing MD5 checksum
Summary: Use std::array when computing MD5 checksum
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-10 06:49 PST by Laszlo Vidacs
Modified: 2013-12-11 14:31 PST (History)
6 users (show)

See Also:


Attachments
Patch (8.85 KB, patch)
2013-12-10 08:28 PST, Laszlo Vidacs
no flags Details | Formatted Diff | Diff
Patch (8.89 KB, patch)
2013-12-10 11:37 PST, Laszlo Vidacs
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Vidacs 2013-12-10 06:49:22 PST
Use std::array instead of custom Vector implementation when calling MD5 checksum(); and use a constant for hash size instead of integer values defined at call sites.
Comment 1 Laszlo Vidacs 2013-12-10 08:28:33 PST
Created attachment 218875 [details]
Patch
Comment 2 Build Bot 2013-12-10 08:59:05 PST
Comment on attachment 218875 [details]
Patch

Attachment 218875 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/45958329
Comment 3 Build Bot 2013-12-10 09:28:29 PST
Comment on attachment 218875 [details]
Patch

Attachment 218875 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/44518192
Comment 4 Laszlo Vidacs 2013-12-10 11:37:55 PST
Created attachment 218886 [details]
Patch
Comment 5 WebKit Commit Bot 2013-12-10 13:45:05 PST
Comment on attachment 218886 [details]
Patch

Clearing flags on attachment: 218886

Committed r160386: <http://trac.webkit.org/changeset/160386>
Comment 6 WebKit Commit Bot 2013-12-10 13:45:06 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Adler 2013-12-11 14:24:02 PST
Comment on attachment 218886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218886&action=review

> Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:213
> +    for (size_t i = 0; i < MD5::hasSize; i++)

This won}t compile because it says “hasSize” instead of “hashSize”.
Comment 8 Laszlo Vidacs 2013-12-11 14:31:34 PST
Thanks for the feedback, the typo fix is already landed in r160430 (https://bugs.webkit.org/show_bug.cgi?id=125571)