Bug 125505 - [WK2][SOUP] WebContext::setIgnoreTLSErrors should send SetIgnoreTLSErrors to the network process when network process is enabled
Summary: [WK2][SOUP] WebContext::setIgnoreTLSErrors should send SetIgnoreTLSErrors to ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kwang Yul Seo
Depends on:
Blocks: 108832
  Show dependency treegraph
Reported: 2013-12-10 05:49 PST by Kwang Yul Seo
Modified: 2013-12-10 07:36 PST (History)
7 users (show)

See Also:

Patch (1.79 KB, patch)
2013-12-10 06:02 PST, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (1.86 KB, patch)
2013-12-10 07:00 PST, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2013-12-10 05:49:37 PST
This is a follow-up patch of r160355 (Bug 125490)
Comment 1 Kwang Yul Seo 2013-12-10 06:02:46 PST
Created attachment 218861 [details]
Comment 2 Carlos Garcia Campos 2013-12-10 06:31:33 PST
Comment on attachment 218861 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=218861&action=review

> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:151
> +        sendToNetworkingProcess(Messages::NetworkProcess::SetIgnoreTLSErrors(m_ignoreTLSErrors));

Here you already know you want to send the message to the network process, so you can call directly networkProcess()->send(Messages::NetworkProcess::SetIgnoreTLSErrors(m_ignoreTLSErrors)); You should probably check also that networkProcess is not null

if (usesNetworkProcess() && networkProcess())
Comment 3 Kwang Yul Seo 2013-12-10 07:00:06 PST
Created attachment 218868 [details]
Comment 4 WebKit Commit Bot 2013-12-10 07:36:51 PST
Comment on attachment 218868 [details]

Clearing flags on attachment: 218868

Committed r160364: <http://trac.webkit.org/changeset/160364>
Comment 5 WebKit Commit Bot 2013-12-10 07:36:54 PST
All reviewed patches have been landed.  Closing bug.