125502 – [EFL][JSC] Enable udis86 disassembler on efl

Bug 125502 - [EFL][JSC] Enable udis86 disassembler on efl

Summary: [EFL][JSC] Enable udis86 disassembler on efl

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-12-10 05:35 PST by Tamas Gergely
Modified:	2014-01-13 06:16 PST (History)
CC List:	10 users (show)

See Also:

Attachments
patch enables udis86 on efl (9.05 KB, patch) 2013-12-10 06:39 PST, Tamas Gergely	msaboff: review+	Details \| Formatted Diff \| Diff
Updated patch. (8.90 KB, patch) 2013-12-11 03:27 PST, Tamas Gergely	eflews.bot: commit-queue-	Details \| Formatted Diff \| Diff
Updated patch. (9.52 KB, patch) 2013-12-11 14:27 PST, Tamas Gergely	msaboff: review+ buildbot: commit-queue-	Details \| Formatted Diff \| Diff
Updated patch 3. (9.54 KB, patch) 2013-12-11 16:34 PST, Tamas Gergely	commit-queue: commit-queue-	Details \| Formatted Diff \| Diff
Updated patch 4. (9.55 KB, patch) 2014-01-10 07:10 PST, Tamas Gergely	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tamas Gergely 2013-12-10 05:35:41 PST

Enable udis86 disassembler for jsc on efl platform.

Comment 1 Tamas Gergely 2013-12-10 06:39:23 PST

Created attachment 218866 [details]
patch enables udis86 on efl

The style checker found 10 whitespace errors, but these files use different styles. The correction is not possible without correcting the style of large code blocks in these files.

Comment 2 WebKit Commit Bot 2013-12-10 06:40:24 PST

Attachment 218866 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/disassembler/udis86/udis86_decode.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h', u'Source/cmake/OptionsEfl.cmake', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:462:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:463:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:109:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:146:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:149:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:152:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:84:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:86:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:130:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:133:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 10 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Michael Saboff 2013-12-10 09:27:52 PST

Comment on attachment 218866 [details]
patch enables udis86 on efl

View in context: https://bugs.webkit.org/attachment.cgi?id=218866&action=review

r=me, but change the (unsigned long long) casts to (uint64_t) casts.

> Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:130
> +				mkasm(u, "0x" FMT64 "x", (unsigned long long)(u->pc + op->lval.sbyte)); 

Please make these casts to uint64_t

Comment 4 Tamas Gergely 2013-12-11 03:27:05 PST

Created attachment 218949 [details]
Updated patch.

Patch for landing.

Comment 5 WebKit Commit Bot 2013-12-11 03:52:59 PST

Attachment 218949 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/disassembler/udis86/udis86_decode.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h', u'Source/cmake/OptionsEfl.cmake', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:462:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:463:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:109:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:146:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:149:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:152:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:84:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:86:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:130:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:133:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 10 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 EFL EWS Bot 2013-12-11 04:00:43 PST

Comment on attachment 218949 [details]
Updated patch.

Attachment 218949 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/45888494

Comment 7 EFL EWS Bot 2013-12-11 04:08:19 PST

Comment on attachment 218949 [details]
Updated patch.

Attachment 218949 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/47308482

Comment 8 Tamas Gergely 2013-12-11 07:19:54 PST

(In reply to comment #3)
> (From update of attachment 218866 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218866&action=review
> 
> r=me, but change the (unsigned long long) casts to (uint64_t) casts.
> 
> > Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:130
> > +				mkasm(u, "0x" FMT64 "x", (unsigned long long)(u->pc + op->lval.sbyte)); 
> 
> Please make these casts to uint64_t

It seems that uint64_t is defined as unsigned long int, while FMT64 is "%ll", and this causes the error. At first it seems to be an inconsistency between the 64bit type definitions, but I'll check it.

Comment 9 Tamas Gergely 2013-12-11 14:27:24 PST

Created attachment 219004 [details]
Updated patch.

Defining FMT64 based on the __WORDSIZE seems to solve the problem.

Comment 10 WebKit Commit Bot 2013-12-11 14:28:38 PST

Attachment 219004 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/disassembler/udis86/udis86_decode.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_types.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h', u'Source/cmake/OptionsEfl.cmake', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:462:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:463:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:109:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:146:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:149:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:152:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:84:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:86:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:130:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:133:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 10 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 11 Build Bot 2013-12-11 15:00:51 PST

Comment on attachment 219004 [details]
Updated patch.

Attachment 219004 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/47008184

Comment 12 Build Bot 2013-12-11 15:30:21 PST

Comment on attachment 219004 [details]
Updated patch.

Attachment 219004 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/48108050

Comment 13 Tamas Gergely 2013-12-11 16:34:07 PST

Created attachment 219015 [details]
Updated patch 3.

Comment 14 WebKit Commit Bot 2013-12-11 16:39:53 PST

Attachment 219015 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/disassembler/udis86/udis86_decode.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_types.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h', u'Source/cmake/OptionsEfl.cmake', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:462:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:463:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:109:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:146:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:149:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:152:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:84:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:86:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:130:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:133:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 10 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 15 WebKit Commit Bot 2014-01-06 01:22:36 PST

Comment on attachment 219015 [details]
Updated patch 3.

Rejecting attachment 219015 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/udis86_syn-att.o disassembler/udis86/udis86_syn-att.c normal x86_64 c com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/udis86_syn-intel.o disassembler/udis86/udis86_syn-intel.c normal x86_64 c com.apple.compilers.llvm.clang.1_0.compiler
(2 failures)

Full output: http://webkit-queues.appspot.com/results/5678205671309312

Comment 16 Tamas Gergely 2014-01-10 07:10:03 PST

Created attachment 220838 [details]
Updated patch 4.

Comment 17 WebKit Commit Bot 2014-01-10 07:11:08 PST

Attachment 220838 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/disassembler/udis86/udis86_decode.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c', u'Source/JavaScriptCore/disassembler/udis86/udis86_types.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h', u'Source/cmake/OptionsEfl.cmake', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:462:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:463:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:109:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:146:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:149:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-intel.c:152:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:84:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:86:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:130:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:133:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 10 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 18 WebKit Commit Bot 2014-01-10 13:33:38 PST

Comment on attachment 220838 [details]
Updated patch 4.

Clearing flags on attachment: 220838

Committed r161672: <http://trac.webkit.org/changeset/161672>