Bug 125487 - Test results of postMessage-clone-port-error.html are broken
Summary: Test results of postMessage-clone-port-error.html are broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michał Poteralski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-10 01:38 PST by Michał Poteralski
Modified: 2013-12-11 02:48 PST (History)
3 users (show)

See Also:

Attachments
Patch no 1 (1.92 KB, patch)
2013-12-10 12:35 PST, Michał Poteralski 		no flags Details | Formatted Diff | Diff
Patch (2.88 KB, patch)
2013-12-11 00:44 PST, Michał Poteralski 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Poteralski 2013-12-10 01:38:15 PST 
Order of: LayoutTests/fast/dom/Window/postMessage-clone-port-error.html is broken.
Currently is:
> LayoutTests/fast/dom/Window/postMessage-clone-port-error-expected.txt:4
> +PASS successfullyParsed is true
> +
> +TEST COMPLETE
> +PASS exName is "DataCloneError"


TEST COMPLETE should be the last line.
Comment 1 Alexey Proskuryakov 2013-12-10 10:01:53 PST 
The easiest way to address this is probably to move the test from onload to being run duting parsing. Alternatively jsTesIsAsync variable could be set, and finishJSTest() called when done.
Comment 2 Michał Poteralski 2013-12-10 12:35:56 PST 
Created attachment 218892 [details]
Patch no 1
Comment 3 Alexey Proskuryakov 2013-12-10 14:06:07 PST 
Comment on attachment 218892 [details]
Patch no 1 

View in context: https://bugs.webkit.org/attachment.cgi?id=218892&action=review

> LayoutTests/fast/dom/Window/postMessage-clone-port-error.html:7
> +<div id='container'></div>

This doesn't seem relevant. Possibly this came from a test that did need it?
Comment 4 Michał Poteralski 2013-12-11 00:44:02 PST 
Created attachment 218936 [details]
Patch
Comment 5 WebKit Commit Bot 2013-12-11 02:48:04 PST 
Comment on attachment 218936 [details]
Patch

Clearing flags on attachment: 218936

Committed r160418: <http://trac.webkit.org/changeset/160418>
Comment 6 WebKit Commit Bot 2013-12-11 02:48:06 PST 
All reviewed patches have been landed.  Closing bug.