Bug 125483 - [Mac] Stop not caching HTTP resources with "Vary" header in response.
Summary: [Mac] Stop not caching HTTP resources with "Vary" header in response.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Performance
Depends on:
Blocks:
 
Reported: 2013-12-09 21:40 PST by Andreas Kling
Modified: 2013-12-12 11:19 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.18 KB, patch)
2013-12-09 21:56 PST, Andreas Kling 		ap: review-
Details | Formatted Diff | Diff
Patch (2.86 KB, patch)
2013-12-09 23:02 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-12-09 21:40:53 PST 
A workaround was added in <http://trac.webkit.org/r120339>, preventing resources with the "Vary" header from being cached.
This was a hack around missing CFNetwork support for Vary headers.

Now that CFNetwork supports this, we should remove the workaround.
Comment 1 Andreas Kling 2013-12-09 21:53:43 PST 
<rdar://problem/15623644>
Comment 2 Andreas Kling 2013-12-09 21:56:18 PST 
Created attachment 218832 [details]
Patch
Comment 3 Brady Eidson 2013-12-09 22:04:18 PST 
This patch removes the workaround on all CFNetwork platforms.

Does CFNetwork now support this on all WebKit-supported platforms?

(I don't know the answer)
Comment 4 Alexey Proskuryakov 2013-12-09 22:18:27 PST 
Comment on attachment 218832 [details]
Patch

> Does CFNetwork now support this on all WebKit-supported platforms?

No.
Comment 5 Antti Koivisto 2013-12-09 22:45:45 PST 
(In reply to comment #4)
> (From update of attachment 218832 [details])
> > Does CFNetwork now support this on all WebKit-supported platforms?
> 
> No.

That's not helpful. Please explain what changes are needed.
Comment 6 Andreas Kling 2013-12-09 23:02:42 PST 
Created attachment 218837 [details]
Patch

Keep the workaround on PLATFORM(WIN) for now.
Comment 7 Alexey Proskuryakov 2013-12-09 23:12:31 PST 
> That's not helpful.

The rest is in Radar, and Andreas saw it.
Comment 8 WebKit Commit Bot 2013-12-12 11:19:52 PST 
Comment on attachment 218837 [details]
Patch

Clearing flags on attachment: 218837

Committed r160498: <http://trac.webkit.org/changeset/160498>
Comment 9 WebKit Commit Bot 2013-12-12 11:19:54 PST 
All reviewed patches have been landed.  Closing bug.