WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125471
Begin working on a UserData class intended to replace UserMessageCoders
https://bugs.webkit.org/show_bug.cgi?id=125471
Summary
Begin working on a UserData class intended to replace UserMessageCoders
Anders Carlsson
Reported
2013-12-09 15:50:42 PST
Begin working on a UserData class intended to replace UserMessageCoders
Attachments
Patch
(25.93 KB, patch)
2013-12-09 15:56 PST
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2013-12-09 15:56:55 PST
Created
attachment 218809
[details]
Patch
Sam Weinig
Comment 2
2013-12-09 16:01:39 PST
Comment on
attachment 218809
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=218809&action=review
> Source/WebKit2/Shared/APIFrameHandle.h:36 > + static PassRefPtr<FrameHandle> create(uint64_t frameID);
You said that RefPtr would be fine here.
> Source/WebKit2/Shared/APIPageHandle.h:36 > + static PassRefPtr<PageHandle> create(uint64_t pageID);
RefPtr here please.
> Source/WebKit2/Shared/UserData.cpp:60 > + encoder.encodeEnum(API::Object::Type::Null);
You don't deal with decoding this.
Anders Carlsson
Comment 3
2013-12-09 16:08:31 PST
Committed
r160341
: <
http://trac.webkit.org/changeset/160341
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug