RESOLVED FIXED 125467
PATH needs to include cygwin for WebKitVersion 
https://bugs.webkit.org/show_bug.cgi?id=125467
Summary PATH needs to include cygwin for WebKitVersion
Alex Christensen
Reported 2013-12-09 14:31:32 PST
http://trac.webkit.org/changeset/159768 broke my build. I guess everyone else has c:\cygwin\bin in their path. That's not a requirement. Here's the fix.
Attachments
Patch (1.31 KB, patch)
2013-12-09 14:35 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-12-09 14:35:03 PST
Created attachment 218801 [details] Patch
Brent Fulgham
Comment 2 2013-12-11 15:06:44 PST
Comment on attachment 218801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218801&action=review r=me > Source/WebKit/WebKit.vcxproj/WebKit/WebKitVersion.cmd:5 > +set PATH=%SystemDrive%\cygwin\bin;%PATH% This assumes that Cygwin is always installed in "C:\cygwin", which may not be the case on all user's systems. Still, it's a reasonable assumption for most people. We might want to check "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Cygwin\setup\rootdir" to get the true location.
WebKit Commit Bot
Comment 3 2013-12-11 15:35:19 PST
Comment on attachment 218801 [details] Patch Clearing flags on attachment: 218801 Committed r160465: <http://trac.webkit.org/changeset/160465>
WebKit Commit Bot
Comment 4 2013-12-11 15:35:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.