Bug 125460 – AX: Audio and video attachments at end of a message are not output to VoiceOver

• Status: ASSIGNED
• Component: Accessibility

[Samuel White]

Audio and video attachments at the end of a Mail message are not navigable by VoiceOver or other AT.

[Samuel White]

<rdar://problem/15528873>

[Samuel White]

Created attachment 218789 [details]
Patch for EWS.

Looking for initial EWS issues.

[WebKit Commit Bot]

Attachment 218789 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/TextIterator.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/editing/TextIterator.cpp:396:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Samuel White]

(In reply to comment #3)
> Attachment 218789 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/TextIterator.cpp', '--commit-queue']" exit_code: 1
> ERROR: Source/WebCore/editing/TextIterator.cpp:396:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
> Total errors found: 1 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Caused by:

m_endOffset == 0

which is existing code. Will update to:

!m_endOffset

in next patch.

[Samuel White]

Created attachment 218800 [details]
Patch.

Added layout test.

[Samuel White]

Created attachment 218803 [details]
Updated patch.

Updated patch to fix Changelog text wrapping issue.

[Build Bot]

Comment on attachment 218803 [details]
Updated patch.

Attachment 218803 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/46278303

New failing tests:
editing/execCommand/remove-format-textdecoration-in-iframe.html
editing/style/5228141.html
editing/pasteboard/styled-element-markup.html
editing/inserting/return-with-object-element.html
editing/deleting/delete-start-block.html
svg/foreignObject/viewport-foreignobject-crash.html

[Build Bot]

Created attachment 218821 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 218803 [details]
Updated patch.

Attachment 218803 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/47348076

New failing tests:
editing/execCommand/remove-format-textdecoration-in-iframe.html
editing/style/5228141.html
editing/pasteboard/styled-element-markup.html
editing/inserting/return-with-object-element.html
editing/deleting/delete-start-block.html
svg/foreignObject/viewport-foreignobject-crash.html

[Build Bot]

Created attachment 218823 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[chris fleizach]

Comment on attachment 218803 [details]
Updated patch.

seems ok to me, fairly similar to other recent replaced element patches, but r- for now until you can figure out if the tests are regressions or not

[Samuel White]

These failures are fairly involved. Digging through them now.