Bug 125452 - [GStreamer] Memory leak due to incorrect use of gst_tag_list_merge in TextCombinerGStreamer
Summary: [GStreamer] Memory leak due to incorrect use of gst_tag_list_merge in TextCom...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brendan Long
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-09 07:32 PST by Brendan Long
Modified: 2013-12-09 08:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2013-12-09 07:34 PST, Brendan Long 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Long 2013-12-09 07:32:19 PST 
[GStreamer] Memory leak due to incorrect use of gst_tag_list_merge in TextCombinerGStreamer
Comment 1 Brendan Long 2013-12-09 07:34:07 PST 
Created attachment 218760 [details]
Patch
Comment 2 Brendan Long 2013-12-09 07:37:44 PST 
The problem with this is that gst_tag_list_merge creates a new list, so calling:

    combinerPad->tags = gst_tag_list_merge(combinerPad->tags, tags);

... Creates a new list and then leaks the old one. gst_tag_list_insert is what I should have used in the first place (and it's what gst_tag_list_merge uses internally).
Comment 3 WebKit Commit Bot 2013-12-09 08:15:46 PST 
Comment on attachment 218760 [details]
Patch

Clearing flags on attachment: 218760

Committed r160312: <http://trac.webkit.org/changeset/160312>
Comment 4 WebKit Commit Bot 2013-12-09 08:15:49 PST 
All reviewed patches have been landed.  Closing bug.