Bug 125451 – AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests.

[Joanmarie Diggs]

Created attachment 218757 [details]
Patch

[Build Bot]

Comment on attachment 218757 [details]
Patch

Attachment 218757 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/44758142

[Build Bot]

Comment on attachment 218757 [details]
Patch

Attachment 218757 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/47228114

[Mario Sanchez Prada]

View in context: https://bugs.webkit.org/attachment.cgi?id=218757&action=review

I love this patch. I'm happy to let it in as soon as the Mac build is fixed

> Source/WebKit/gtk/tests/testatk.c:-1070
> -    webkit_web_view_load_string(webView, contentsWithEmbeddedObjects, 0, 0, 0);

Could you remove the contentsWithEmbeddedObjects const variable, as it's not used anymore after the patch? Same applies to other ones that might not be unused too after this

> Tools/DumpRenderTree/AccessibilityUIElement.h:220
> +    // Text-specific
> +    JSStringRef characterAtOffset(int offset);
> +    JSStringRef wordAtOffset(int offset);
> +    JSStringRef lineAtOffset(int offset);
> +    JSStringRef sentenceAtOffset(int offset);

This functions are quite specifically designed to test the AtkText interface, so I think you should put them under a PLATFORM check for GTK || EFL

Otherwise, you'll need to provide dummy implementations for other platforms's versions of AccessibilityUIElement

[Build Bot]

Comment on attachment 218757 [details]
Patch

Attachment 218757 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/44758147

[Joanmarie Diggs]

Created attachment 218766 [details]
Patch

[Build Bot]

Comment on attachment 218766 [details]
Patch

Attachment 218766 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/47238121

[Build Bot]

Comment on attachment 218766 [details]
Patch

Attachment 218766 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/47238124

[Joanmarie Diggs]

Created attachment 218770 [details]
Patch

[Build Bot]

Comment on attachment 218770 [details]
Patch

Attachment 218770 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/45888143

[Joanmarie Diggs]

Created attachment 218772 [details]
Patch

[Mario Sanchez Prada]

Comment on attachment 218772 [details]
Patch

Great. Let's try this now (and watch)

[WebKit Commit Bot]

Comment on attachment 218772 [details]
Patch

Clearing flags on attachment: 218772

Committed r160316: <http://trac.webkit.org/changeset/160316>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.