Bug 125444 - [GTK] REGRESSION: www.yahoo.com redirects to the mobile version after UA change
: [GTK] REGRESSION: www.yahoo.com redirects to the mobile version after UA change
Status: RESOLVED FIXED
: WebKit
WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
: http://www.yahoo.com
:
:
:
  Show dependency treegraph
 
Reported: 2013-12-09 03:10 PST by
Modified: 2013-12-10 06:03 PST (History)


Attachments
Patch (3.02 KB, patch)
2013-12-09 10:11 PST, Gustavo Noronha (kov)
mrobinson: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2013-12-09 03:10:24 PST
The recent UA change from bug 124229 triggered this because if I revert to the old UA then I get the desktop version.
------- Comment #1 From 2013-12-09 09:38:05 PST -------
Related: bug 125432
------- Comment #2 From 2013-12-09 10:11:49 PST -------
Created an attachment (id=218773) [details]
Patch
------- Comment #3 From 2013-12-09 10:22:23 PST -------
I cannot reproduce this with Epiphany btw :?
------- Comment #4 From 2013-12-09 10:28:29 PST -------
Ah yeah, if I replace X11; Linux x86_64 with X11; Intel Mac OS X then
it redirects.
------- Comment #5 From 2013-12-09 10:32:46 PST -------
(In reply to comment #2)
> Created an attachment (id=218773) [details] [details]
> Patch

This patch is very similar with my first one

https://bug-124229-attachments.webkit.org/attachment.cgi?id=216802

But @mrobinson commented this https://bugs.webkit.org/show_bug.cgi?id=124229#c8

So I think we're in a kind of a dilemma: some site will redirect us if change it; some other will do too if we doesn't.
------- Comment #6 From 2013-12-09 10:50:55 PST -------
I don't get your point Victor, what this patch does is claim to be Mac OS X properly (by not keeping the X11), it doesn't contradict Martin's comment you linked to. Do you know of a site that breaks with this patch?
------- Comment #7 From 2013-12-09 11:12:40 PST -------
(In reply to comment #6)
> I don't get your point Victor, what this patch does is claim to be Mac OS X properly (by not keeping the X11), it doesn't contradict Martin's comment you linked to. Do you know of a site that breaks with this patch?

oops! Sorry, I misread your patch. Now I got it. Thanks!
------- Comment #8 From 2013-12-09 11:18:09 PST -------
(In reply to comment #7)
> oops! Sorry, I misread your patch. Now I got it. Thanks!

o/\o
------- Comment #9 From 2013-12-09 20:00:26 PST -------
(In reply to comment #2)
> Created an attachment (id=218773) [details] [details]
> Patch

I'm curious how the Windows build managed to succeed - just by looking at the patch I would have expected it to fail on an undefined cpuDescriptionForUAString() since the #if guard for that version is not removed.
------- Comment #10 From 2013-12-09 21:04:13 PST -------
(In reply to comment #9)
> (In reply to comment #2)
> > Created an attachment (id=218773) [details] [details] [details]
> > Patch
> 
> I'm curious how the Windows build managed to succeed - just by looking at the patch I would have expected it to fail on an undefined cpuDescriptionForUAString() since the #if guard for that version is not removed.

Oh right, the Windows build is not a WebKitGTK+ build.
------- Comment #11 From 2013-12-10 00:32:57 PST -------
(From update of attachment 218773 [details])
I'm all for the patch
------- Comment #12 From 2013-12-10 02:17:43 PST -------
Committed r160354: <http://trac.webkit.org/changeset/160354>