In manager.py, BUILDER_BASE_URL is passed to JSONLayoutResultsGenerator which passes it to JSONResultsGenerator, but the last one doesn't use it at all. It seems to be a leftover from Chromium.
Created attachment 218739 [details] Patch
Comment on attachment 218739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218739&action=review > Tools/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). > + Why are we removing it?
(In reply to comment #2) > (From update of attachment 218739 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218739&action=review > > > Tools/ChangeLog:7 > > + Reviewed by NOBODY (OOPS!). > > + > > Why are we removing it? It's completely useless, and I don't see any reason why we should keep it this way. Someone must have forgotten removing it, along with other Chromium stuff.
Comment on attachment 218739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218739&action=review >>> Tools/ChangeLog:7 >>> + >> >> Why are we removing it? > > It's completely useless, and I don't see any reason why we should keep it this way. Someone must have forgotten removing it, along with other Chromium stuff. Please explain that in the change log. r- due to the lack of description in the change log.
Created attachment 218957 [details] Patch - ChangeLog updated
Comment on attachment 218957 [details] Patch - ChangeLog updated Clearing flags on attachment: 218957 Committed r160900: <http://trac.webkit.org/changeset/160900>
All reviewed patches have been landed. Closing bug.