RESOLVED FIXED 125442
webkitpy: remove unused BUILDER_BASE_URL 
https://bugs.webkit.org/show_bug.cgi?id=125442
Summary webkitpy: remove unused BUILDER_BASE_URL
Peter Molnar
Reported 2013-12-09 01:35:49 PST
In manager.py, BUILDER_BASE_URL is passed to JSONLayoutResultsGenerator which passes it to JSONResultsGenerator, but the last one doesn't use it at all. It seems to be a leftover from Chromium.
Attachments
Patch (4.79 KB, patch)
2013-12-09 01:38 PST, Peter Molnar 		rniwa: review-
rniwa: commit-queue-
DetailsFormatted DiffDiff
Patch - ChangeLog updated (4.98 KB, patch)
2013-12-11 06:25 PST, Peter Molnar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Molnar
Comment 1 2013-12-09 01:38:41 PST
Created attachment 218739 [details] Patch
Ryosuke Niwa
Comment 2 2013-12-09 10:31:33 PST
Comment on attachment 218739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218739&action=review > Tools/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). > + Why are we removing it?
Peter Molnar
Comment 3 2013-12-09 14:31:48 PST
(In reply to comment #2) > (From update of attachment 218739 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218739&action=review > > > Tools/ChangeLog:7 > > + Reviewed by NOBODY (OOPS!). > > + > > Why are we removing it? It's completely useless, and I don't see any reason why we should keep it this way. Someone must have forgotten removing it, along with other Chromium stuff.
Ryosuke Niwa
Comment 4 2013-12-09 14:42:50 PST
Comment on attachment 218739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218739&action=review >>> Tools/ChangeLog:7 >>> + >> >> Why are we removing it? > > It's completely useless, and I don't see any reason why we should keep it this way. Someone must have forgotten removing it, along with other Chromium stuff. Please explain that in the change log. r- due to the lack of description in the change log.
Peter Molnar
Comment 5 2013-12-11 06:25:29 PST
Created attachment 218957 [details] Patch - ChangeLog updated
WebKit Commit Bot
Comment 6 2013-12-20 02:57:32 PST
Comment on attachment 218957 [details] Patch - ChangeLog updated Clearing flags on attachment: 218957 Committed r160900: <http://trac.webkit.org/changeset/160900>
WebKit Commit Bot
Comment 7 2013-12-20 02:57:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.