Bug 125441 – [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alejandro G. Castro]

It is causing issues in the my environment when building the xml file output.

[Alejandro G. Castro]

Created attachment 218738 [details]
Patch

[Martin Robinson]

Comment on attachment 218738 [details]
Patch

Hrm...what is the issue with escaping?

[Alejandro G. Castro]

(In reply to comment #2)
> (From update of attachment 218738 [details])
> Hrm...what is the issue with escaping?

It is building the pathname incorrectly, replacing using some pathname, and as the next line shows it is not required. I'm also interested on knowing what python is actually doing :).

[Alejandro G. Castro]

So, apparently it is a bug in some versions of valgrind, just checked if you run this it fails:

VALGRIND_OPTS='--xml-file="/tmp/errors.xml"' valgrind /bin/ps
valgrind: can't create XML file '/tmp/"/tmp/errors.xml"': No such file or directory

My version is 3.8.1 in fedora 18. Considering we do not need the double quotes because we define the file name, it is safe to remove them and we can forget about this bug. I'll modify the information about the problem and upload the patch.

[Alejandro G. Castro]

Created attachment 218971 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 218971 [details]
Patch

Clearing flags on attachment: 218971

Committed r160448: <http://trac.webkit.org/changeset/160448>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.