125441 – [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py

Bug 125441 - [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py

Summary: [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKitGTK (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Linux

Importance:	P2 Normal
Assignee:	Alejandro G. Castro

URL:
Keywords:

Depends on:
Blocks:	116317
	Show dependency tree / graph

Reported:	2013-12-09 01:27 PST by Alejandro G. Castro
Modified:	2013-12-11 11:00 PST (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (1.32 KB, patch) 2013-12-09 01:34 PST, Alejandro G. Castro	no flags	Details \| Formatted Diff \| Diff
Patch (1.39 KB, patch) 2013-12-11 09:12 PST, Alejandro G. Castro	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alejandro G. Castro 2013-12-09 01:27:24 PST

It is causing issues in the my environment when building the xml file output.

Comment 1 Alejandro G. Castro 2013-12-09 01:34:02 PST

Created attachment 218738 [details]
Patch

Comment 2 Martin Robinson 2013-12-09 01:50:07 PST

Comment on attachment 218738 [details]
Patch

Hrm...what is the issue with escaping?

Comment 3 Alejandro G. Castro 2013-12-09 02:01:07 PST

(In reply to comment #2)
> (From update of attachment 218738 [details])
> Hrm...what is the issue with escaping?

It is building the pathname incorrectly, replacing using some pathname, and as the next line shows it is not required. I'm also interested on knowing what python is actually doing :).

Comment 4 Alejandro G. Castro 2013-12-11 09:02:50 PST

So, apparently it is a bug in some versions of valgrind, just checked if you run this it fails:

VALGRIND_OPTS='--xml-file="/tmp/errors.xml"' valgrind /bin/ps
valgrind: can't create XML file '/tmp/"/tmp/errors.xml"': No such file or directory

My version is 3.8.1 in fedora 18. Considering we do not need the double quotes because we define the file name, it is safe to remove them and we can forget about this bug. I'll modify the information about the problem and upload the patch.

Comment 5 Alejandro G. Castro 2013-12-11 09:12:04 PST

Created attachment 218971 [details]
Patch

Comment 6 WebKit Commit Bot 2013-12-11 11:00:25 PST

Comment on attachment 218971 [details]
Patch

Clearing flags on attachment: 218971

Committed r160448: <http://trac.webkit.org/changeset/160448>

Comment 7 WebKit Commit Bot 2013-12-11 11:00:28 PST

All reviewed patches have been landed.  Closing bug.