Bug 125434 - check-webkit-style thinks that the super-constructor initialization needs "Comma should be at the beginning of the line in a member initialization list."
Summary: check-webkit-style thinks that the super-constructor initialization needs "Co...
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-08 20:05 PST by Filip Pizlo
Modified: 2014-03-21 03:41 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-12-08 20:05:33 PST 
The following code:

class SSALoweringPhase : public Phase {
    static const bool verbose = false;
    
public:
    SSALoweringPhase(Graph& graph)
        : Phase(graph, "SSA lowering")
        , m_insertionSet(graph)
    {
    }

Causes check-webkit-style to claim that the ": Phase(graph, ..." line needs a comma.
Comment 1 Laszlo Vidacs 2013-12-18 01:58:17 PST 
Failed to reproduce the error. No error message issued with r160755, tried on the example code and on DFGSSALoweringPhase.cpp
Comment 2 Laszlo Vidacs 2014-03-21 03:41:31 PDT 
No error message in 166057.