Bug 125420 - 32-bit MiniBrowser doesn't build
Summary: 32-bit MiniBrowser doesn't build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-08 11:02 PST by Simon Fraser (smfr)
Modified: 2013-12-08 20:51 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2013-12-08 20:46 PST, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-12-08 11:02:07 PST 
WK_API_ENABLED isn't defined for 32-bit, so the API-using MiniBrowser doesn't build.

I guess we should just not build MiniBrowser for 32-bit? What if WTR wants to use WebKit2 API?
Comment 1 Simon Fraser (smfr) 2013-12-08 11:02:27 PST 
Also, this is breaking the build:
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29
Comment 2 Sam Weinig 2013-12-08 20:46:07 PST 
Created attachment 218723 [details]
Patch
Comment 3 Sam Weinig 2013-12-08 20:48:13 PST 
(In reply to comment #0)
> WK_API_ENABLED isn't defined for 32-bit, so the API-using MiniBrowser doesn't build.
> 
> I guess we should just not build MiniBrowser for 32-bit? 

I'm just going to fix the issue I introduced.  But I am not sure there is value in building 32-bit.

> What if WTR wants to use WebKit2 API?

I don't think this is likely, at least anytime soon, since WTR is cross-platform.
Comment 4 Sam Weinig 2013-12-08 20:48:30 PST 
Committed r160298: <http://trac.webkit.org/changeset/160298>
Comment 5 mitz 2013-12-08 20:51:20 PST 
(In reply to comment #0)
> WK_API_ENABLED isn't defined for 32-bit, so the API-using MiniBrowser doesn't build.
> 
> I guess we should just not build MiniBrowser for 32-bit? What if WTR wants to use WebKit2 API?

WebKitTestRunner is cross-platform so it’s not expected to need the Cocoa API. In the future, if we retire the cross-platform C SPI, we might want to transition WebKitTestRunner to some C++ SPI.