Bug 125417 - [GTK] Do not skip attributes with only custom setter
Summary: [GTK] Do not skip attributes with only custom setter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 125416
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-08 09:43 PST by Carlos Garcia Campos
Modified: 2013-12-08 10:19 PST (History)
4 users (show)

See Also:


Attachments
Patch (18.61 KB, patch)
2013-12-08 09:49 PST, Carlos Garcia Campos
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-12-08 09:43:27 PST
We are currently skipping any argument having a custom setter or getter. In case of objects having a custom setter, we can generate the attribute as readonly and skip only the getter.
Comment 1 Carlos Garcia Campos 2013-12-08 09:49:19 PST
Created attachment 218696 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-12-08 10:05:20 PST
Comment on attachment 218696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218696&action=review

> Source/WebCore/ChangeLog:9
> +        * bindings/gobject/GNUmakefile.am: Generate
> +        WebKitDOMMediaController that is now required by an attribute

This could be a longer line =P

> Source/WebCore/ChangeLog:11
> +        * bindings/gobject/WebKitDOMCustom.cpp: Remove mothods that are now generated.

*mothods

> Source/WebCore/ChangeLog:16
> +        (SkipAttribute): Do not skip attributes having a custom setter.

Can you change the description to say we will now generate getters for properties that have custom setters? I was confused for a while.
Comment 3 Carlos Garcia Campos 2013-12-08 10:19:43 PST
Committed r160289: <http://trac.webkit.org/changeset/160289>