RESOLVED FIXED 125415
[WK2] Guard include of SecItemShim.h with ENABLE(SEC_ITEM_SHIM) 
https://bugs.webkit.org/show_bug.cgi?id=125415
Summary [WK2] Guard include of SecItemShim.h with ENABLE(SEC_ITEM_SHIM)
Brian Holt
Reported 2013-12-08 08:01:33 PST
NetworkProcess.cpp and NetworkProcessProxy.cpp both include SecItemShim.h unguarded.
Attachments
Patch (2.20 KB, patch)
2013-12-08 08:13 PST, Brian Holt 		no flags
DetailsFormatted DiffDiff
Patch (2.21 KB, patch)
2013-12-08 09:20 PST, Brian Holt 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brian Holt
Comment 1 2013-12-08 08:13:54 PST
Created attachment 218690 [details] Patch
Gustavo Noronha (kov)
Comment 2 2013-12-08 08:34:24 PST
Comment on attachment 218690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218690&action=review > Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:41 > -#include "SecItemShimProxy.h" > #include "WebContext.h" > #include "WebProcessMessages.h" > #include <wtf/RunLoop.h> > > +#if ENABLE(SEC_ITEM_SHIM) > +#include "SecItemShim.h" SecItemShim.h != SecItemShimProxy.h, intended?
Build Bot
Comment 3 2013-12-08 08:49:48 PST
Comment on attachment 218690 [details] Patch Attachment 218690 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/46658037
Build Bot
Comment 4 2013-12-08 09:05:08 PST
Comment on attachment 218690 [details] Patch Attachment 218690 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/46658040
Brian Holt
Comment 5 2013-12-08 09:20:11 PST
Created attachment 218693 [details] Patch
Brian Holt
Comment 6 2013-12-08 09:45:53 PST
Comment on attachment 218693 [details] Patch Thanks for the review - could you set CQ+?
WebKit Commit Bot
Comment 7 2013-12-08 10:23:17 PST
Comment on attachment 218693 [details] Patch Clearing flags on attachment: 218693 Committed r160290: <http://trac.webkit.org/changeset/160290>
WebKit Commit Bot
Comment 8 2013-12-08 10:23:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.