RESOLVED FIXED Bug 125410
[Soup] Send original encoded data size to didReceiveBuffer 
https://bugs.webkit.org/show_bug.cgi?id=125410
Summary [Soup] Send original encoded data size to didReceiveBuffer
Martin Robinson
Reported 2013-12-08 05:55:01 PST
didReceiveBuffer/didReceiveData accepts the original (encoded) data size, but the libsoup backend is always sending the decoded data size.
Attachments
Patch (5.18 KB, patch)
2013-12-08 07:07 PST, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
Patch (5.85 KB, patch)
2013-12-09 11:01 PST, Gustavo Noronha (kov) 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2013-12-08 07:07:11 PST
Created attachment 218687 [details] Patch
Dan Winship
Comment 2 2013-12-08 23:53:36 PST
Comment on attachment 218687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218687&action=review > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:607 > + while (!G_IS_SEEKABLE(baseStream)) > + baseStream = g_filter_input_stream_get_base_stream(G_FILTER_INPUT_STREAM(baseStream)); This assumes you will always eventually find a seekable stream... does this code get used for non-http requests as well? (eg, data: URIs) Also, be sure to test that it works right with resources returned from cache
Gustavo Noronha (kov)
Comment 3 2013-12-09 05:51:30 PST
I'm going to run the tests in debug mode and test that it's working with cached resources (though I think the inspector treats those specially). I'm pretty sure the data: URIs use that code indeed, good catch!
Gustavo Noronha (kov)
Comment 4 2013-12-09 11:01:59 PST
Created attachment 218778 [details] Patch
Martin Robinson
Comment 5 2013-12-09 11:26:49 PST
Comment on attachment 218778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218778&action=review > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:739 > + d->m_previousPosition = handle->currentStreamPosition(); > + Maybe try removing this...
Gustavo Noronha (kov)
Comment 6 2013-12-10 02:04:40 PST
Committed r160352: <http://trac.webkit.org/changeset/160352>
Note You need to log in before you can comment on or make changes to this bug.