RESOLVED FIXED125408
[webkitpy] Add a WestonDriver unit test 
https://bugs.webkit.org/show_bug.cgi?id=125408
Summary [webkitpy] Add a WestonDriver unit test
Zan Dobersek
Reported 2013-12-08 04:24:33 PST
[webkitpy] Add a WestonDriver unit test
Attachments
Patch (5.40 KB, patch)
2013-12-08 04:45 PST, Zan Dobersek 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-12-08 04:45:13 PST
Created attachment 218682 [details] Patch
Gustavo Noronha (kov)
Comment 2 2013-12-08 07:48:09 PST
Comment on attachment 218682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218682&action=review > Tools/Scripts/webkitpy/port/westondriver_unittest.py:67 > + driver._weston_process = None I don't really get this one, why do you do this here? Looks good otherwise.
Zan Dobersek
Comment 3 2013-12-08 08:38:23 PST
(In reply to comment #2) > (From update of attachment 218682 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218682&action=review > > > Tools/Scripts/webkitpy/port/westondriver_unittest.py:67 > > + driver._weston_process = None > > I don't really get this one, why do you do this here? Looks good otherwise. This prevents calling terminate() on the subprocess.Popen mock representation, on which there's no method of such name. This (proper cleanup in WestonDriver.stop()) is rather tested in test_stop() instead. I'll put a comment above this assignment line, explaining why it is done.
Zan Dobersek
Comment 4 2013-12-08 08:47:04 PST
Committed r160286: <http://trac.webkit.org/changeset/160286>
Note You need to log in before you can comment on or make changes to this bug.