Bug 125403 - [Cocoa] Make WKWebProcessPlugInBrowserContextController work with WKObject wrapping
Summary: [Cocoa] Make WKWebProcessPlugInBrowserContextController work with WKObject wr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-07 21:11 PST by Sam Weinig
Modified: 2013-12-07 21:19 PST (History)
0 users

See Also:

Attachments
Patch (13.34 KB, patch)
2013-12-07 21:12 PST, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-12-07 21:11:56 PST 
[Cocoa] Make WKWebProcessPlugInBrowserContextController work with WKObject wrapping
Comment 1 Sam Weinig 2013-12-07 21:12:23 PST 
Created attachment 218675 [details]
Patch
Comment 2 mitz 2013-12-07 21:18:19 PST 
Comment on attachment 218675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218675&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:89
> +- (id)_initWithPrincipalClassInstance:(id<WKWebProcessPlugIn>)principalClassInstance bundle:(InjectedBundle&)bundle

Can you add a space before the < while you’re here?

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:35
> +- (id)_initWithPrincipalClassInstance:(id<WKWebProcessPlugIn>)principalClassInstance bundle:(WebKit::InjectedBundle&)bundle;

Ditto.
Comment 3 Sam Weinig 2013-12-07 21:19:03 PST 
Committed r160277: <http://trac.webkit.org/changeset/160277>